Upgrade .Net Core 3 SDK from preview5 to preview6 and related out of band Nuget packages from 2.1 to 3.0-preview6 #9888
Next
Next commit
Upgrade .Net Core 3 SDK from preview5 to preview6 and keep NuGet pack…
…age Microsoft.AspNetCore.Mvc.NewtonsoftJson used for testing in sync with it
- Loading branch information
commit bc7a14a7a5bd64de4b8a7b15710a412a92c82e44
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "3.0.100-preview6-012264" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should update all packages to latest versions. (As soon as we can compile the PR and pass tests.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which other packages? This is the only package that I was aware of that is tightly coupled to the runtime
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All. Packages we use come from .Net Core 2.*. We need to update to latest preview 3.0.
See #9780
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks for the reference, I updated all those NuGet packages in a 2nd branch and ran the CI tests and there were only 2 failures on Windows only, if you want I could add this update to this PR (especially since the packages are preview6 specific)?
https://christophbergmeister.visualstudio.com/PowerShell/_build/results?buildId=896&view=ms.vss-test-web.build-test-results-tab
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I propose to update step by step (package by package) in the PR. I hope we get this in Preview2 before Core RC.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iSazonov I found the culprit that contains the breaking change that causes the 2 test failures:
System.ServiceProcess.ServiceController. Therefore we can probably update all NuGet packages except this one andMicrosoft.Windows.Compatibility(because it depends onSystem.ServiceProcess.ServiceController). I am running builds at the moment in my fork to prove this theory. Should I also update the packages intools\packages\....(that I think are used to create the NuGet packages for SMA, etc.)? Should the update of possible NuGet packages be in this PR or in a follow up PR (that I'd base it on this PR?)?