Skip to content

Change Microsoft.PowerShell.Commands.SetDateCommand.SystemTime to struct. #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iSazonov merged 3 commits into from
Jan 25, 2018
Merged

Change Microsoft.PowerShell.Commands.SetDateCommand.SystemTime to struct. #6006

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdd7e2b
Change Microsoft.PowerShell.Commands.SetDateCommand.SystemTime to str…
stknohg Jan 24, 2018
7ea2551
fix casing of cmdlet, pester operators.
stknohg Jan 24, 2018
b776585
Use ShouldBeErrorId helper to check error.
stknohg Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix casing of cmdlet, pester operators.
  • Loading branch information
@stknohg
stknohg committed Jan 24, 2018
commit 7ea25512b9b14227ecf6b226c16a866b21bfd405
8 changes: 4 additions & 4 deletions test/powershell/Modules/Microsoft.PowerShell.Utility/Set-Date.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ Describe "Set-Date" -Tag "CI" {
}

It "Set-Date should be able to set the date in an elevated context" -Skip:(! $IsElevated) {
{ get-date | set-date } | Should not throw
{ Get-Date | Set-Date } | Should Not Throw
}

It "Set-Date should be able to set the date with -Date parameter" -Skip:(! $IsElevated) {
$target = Get-Date
$expected = $target
Set-Date -Date $target | Should be $expected
Set-Date -Date $target | Should Be $expected
}

It "Set-Date should produce an error in a non-elevated context" -Skip:($IsElevated) {
{ get-date | set-date} | should throw
$Error[0].FullyQualifiedErrorId | should be "System.ComponentModel.Win32Exception,Microsoft.PowerShell.Commands.SetDateCommand"
{ Get-Date | Set-Date } | Should Throw
Copy link
Copy Markdown
Contributor

@markekraus markekraus Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to use ShouldBeErrorId

https://github.com/PowerShell/PowerShell/blob/master/docs/testing-guidelines/WritingPesterTests.md

Copy link
Copy Markdown
Contributor Author

@stknohg stknohg Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK😄

$Error[0].FullyQualifiedErrorId | Should Be "System.ComponentModel.Win32Exception,Microsoft.PowerShell.Commands.SetDateCommand"
}
}