Skip to content

Speed up check for suspicious content #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzybkr merged 4 commits into from
Nov 3, 2017
Merged

Speed up check for suspicious content #5302

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a44c7f
Speed up check for suspicious content
lzybkr Nov 2, 2017
357e985
Address review feedback
lzybkr Nov 2, 2017
91de31e
Address code review feedback
lzybkr Nov 2, 2017
829fa44
Make loop comment clearer
lzybkr Nov 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review feedback
  • Loading branch information
@lzybkr
lzybkr committed Nov 2, 2017
commit 357e985fca78e7fe414589890f317d7120be24a5
7 changes: 3 additions & 4 deletions src/System.Management.Automation/engine/runtime/CompiledScriptBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1743,11 +1743,10 @@ public static string Match(string text)
{
h = h | 0x20; // ToLower
}

// If the character isn't in any of our patterns,
// don't bother hashing and reset the running length.
if (!((h >= 'a' && h <= 'z') || h == '-'))
else if (!((h >= 'a' && h <= 'z') || h == '-'))
{
// If the character isn't in any of our patterns,
// don't bother hashing and reset the running length.
longestPossiblePattern = 0;
continue;
}
Expand Down