For reliability, start using pester PassThru object to verify tests passed by TravisEz13 · Pull Request #4644 · PowerShell/PowerShell

TravisEz13 · 2017-08-22T19:06:04Z

This should fix #4641.
Thanks, @markekraus for reporting.

anmenaga · 2017-08-22T22:23:38Z

Why was this added?

Unelevate cannot be used with PassThru. Just making sure no one tries. PassThru didn't even work anymore.

I'll file an issue to move the Unelevated tests to use the same mechanism to verify that the tests passed, which should get rid of this.

anmenaga · 2017-08-22T22:25:39Z

Looking at the code below, when TotalCount is 0 that means no test were run.
Will this where-object filter work as expected in this case (TotalCount is 0)?

anmenaga · 2017-08-22T22:26:27Z

Should this be 'xml' ?

anmenaga · 2017-08-22T22:28:04Z

Typo 'unknown'.

markekraus · 2017-08-22T22:42:23Z

add a space between if and (

markekraus · 2017-08-22T22:43:25Z

move { to new line

markekraus · 2017-08-22T22:44:16Z

Move { to new line

markekraus · 2017-08-22T22:46:00Z

add space between if and (

markekraus · 2017-08-22T22:46:25Z

add space between elseif and (

markekraus · 2017-08-22T22:47:00Z

move { to new line

markekraus · 2017-08-22T22:47:40Z

add space between elseif and (

markekraus · 2017-08-22T22:48:01Z

add space between if and (

markekraus · 2017-08-22T22:48:22Z

add space between elseif and (

daxian-dbw · 2017-08-23T05:01:08Z

+                try 
+                {
+                    $Command += "|Export-Clixml -Path '$passThruFile' -Force"
+                    Start-NativeExecution -sb {& $powershell -noprofile -c $Command} | ForEach-Object { Write-Host $_}


Since all output from Invoke-Pester will be captured by Export-Clixml, what will be passed to Foreach-Object?

Only the PassThru object is captured by Export-Clixml... everything else is done by a write host, but when we run another PowerShell process that gets turned into an output. Thus, the complexity ( I have to turn it back into a write-host)

daxian-dbw · 2017-08-23T05:34:03Z

+    $pesterParam = @{ 
+        'binDir'   = $output 
+        'PassThru' = $true
+    }


Why does this issue only happen to Travis CI? I assume it doesn't happen in AppVeyor as AppVeyor.psm1 is not chnaged to use the new parameter -PassThru.

Due to the use of -Unelevate

@anmenaga already asked a question, why I marked these two options as mutually exclusive. I plan on making the code paths more similar after this gets merged.

iSazonov · 2017-08-23T08:08:28Z

May be useful comment

TravisEz13 requested review from adityapatwardhan and daxian-dbw as code owners August 22, 2017 19:06

msftclas added the cla-already-signed label Aug 22, 2017

anmenaga suggested changes Aug 22, 2017

View reviewed changes

markekraus reviewed Aug 22, 2017

View reviewed changes

Comment thread build.psm1 Outdated

Copy link
Copy Markdown

Contributor

markekraus Aug 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move { to new line

markekraus reviewed Aug 22, 2017

View reviewed changes

TravisEz13 added 3 commits August 22, 2017 16:03

Add ability to verify a test run using the -passthru object from pester

d0ddf5d

update travis-ci to use -passthru object to verify test results

3773283

Address PR feedback

cc04525

TravisEz13 force-pushed the FixTestsFailingWithoutBuildFailing branch from 74b99ae to cc04525 Compare August 22, 2017 23:03

TravisEz13 mentioned this pull request Aug 22, 2017

start-pspester -unelevate should use the passthru mechanism to verify tests pass #4648

Closed

TravisEz13 assigned daxian-dbw Aug 22, 2017

call show-pspestererror with a named parameter

996c4af

anmenaga approved these changes Aug 23, 2017

View reviewed changes

daxian-dbw reviewed Aug 23, 2017

View reviewed changes

daxian-dbw merged commit 6a68838 into PowerShell:master Aug 26, 2017

TravisEz13 deleted the FixTestsFailingWithoutBuildFailing branch August 28, 2017 17:12

Conversation

TravisEz13 commented Aug 22, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 Aug 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 Aug 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov commented Aug 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

TravisEz13 Aug 22, 2017 •

edited

Loading

TravisEz13 Aug 23, 2017 •

edited

Loading