Skip to content

Fix build version handling when creating SemanticVersion objects#3793

Merged
mirichmo merged 1 commit intoPowerShell:masterfrom
mklement0:fix-semver-from-ver-constructor
May 17, 2017
Merged

Fix build version handling when creating SemanticVersion objects#3793
mirichmo merged 1 commit intoPowerShell:masterfrom
mklement0:fix-semver-from-ver-constructor

Conversation

@mklement0
Copy link
Copy Markdown
Contributor

@mklement0 mklement0 commented May 16, 2017 •
edited by mirichmo
Loading

Fix #3786

The appropriate [SemanticVersion] constructor now accepts a [version] instance that has only major and minor components specified, in which case the patch component now defaults to 0.

@mklement0
Fix for PowerShell#3786
2a43102 
The appropriate [SemanticVersion] constructor now accepts a [version] instance that has only major and minor components specified, in which case the patch component now defaults to 0.
@msftclas
Copy link
Copy Markdown

msftclas commented May 16, 2017

@mklement0,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@msftclas
Copy link
Copy Markdown

msftclas commented May 16, 2017

@mklement0, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

SteveL-MSFT
SteveL-MSFT approved these changes May 16, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mklement0
Copy link
Copy Markdown
Contributor Author

mklement0 commented May 16, 2017

@SteveL-MSFT Thanks; could you please also close the associated issue, #3786?

@mklement0 mklement0 closed this May 16, 2017
@mklement0 mklement0 deleted the fix-semver-from-ver-constructor branch May 16, 2017 21:08
@lzybkr
Copy link
Copy Markdown
Contributor

lzybkr commented May 16, 2017

Did you mean to close this? It wasn't merged, and can't be merged now because the branch was deleted.

@mklement0 mklement0 restored the fix-semver-from-ver-constructor branch May 16, 2017 23:06
@mklement0
Copy link
Copy Markdown
Contributor Author

mklement0 commented May 16, 2017

@lzybkr Sorry, my bad: I though it was already merged.

@mklement0 mklement0 reopened this May 16, 2017
@msftclas
Copy link
Copy Markdown

msftclas commented May 16, 2017

@mklement0,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@mirichmo mirichmo self-assigned this May 17, 2017
@mirichmo mirichmo changed the title Fix for #3786 Fix build version handling when creating SemanticVersion objects May 17, 2017
@mirichmo
Copy link
Copy Markdown
Member

mirichmo commented May 17, 2017

I updated the title and description to conform to our specs.

@mirichmo mirichmo merged commit 30b97a5 into PowerShell:master May 17, 2017
@mklement0 mklement0 deleted the fix-semver-from-ver-constructor branch May 17, 2017 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SteveL-MSFT SteveL-MSFT SteveL-MSFT approved these changes

Assignees

@mirichmo mirichmo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mklement0 @msftclas @lzybkr @mirichmo @SteveL-MSFT