Get-Help should find help files under $pshome by chunqingchen · Pull Request #3528 · PowerShell/PowerShell

chunqingchen · 2017-04-11T11:22:32Z

Relevant issue: #2653 #2649

Steps to reproduce

get-help about*
Expected behavior

get-help should be able to find the latest help files under $pshome

Actual behavior

get-help only get the files from C:\Windows\System32\WindowsPowerShell\v1.0

Environment data

> $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.15016.1000
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.15016.1000
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

iSazonov · 2017-04-11T12:47:00Z

If we use SilentlyContinue we do not need to use Test-Path.
We can move New-Item's in BeforeAll:

BeforeAll { $helpFile = "about_testCase.help.txt" New-Item -ItemType Directory -Path "$PSHOME\en-US" -ErrorAction SilentlyContinue New-Item -ItemType File -Path "$PSHOME\en-US\$helpFile" -Value "about_test" -ErrorAction SilentlyContinue }

iSazonov · 2017-04-11T12:47:28Z

Please move it to AfterAll.

iSazonov · 2017-04-11T12:48:17Z

You missed "}".

iSazonov · 2017-04-11T12:48:46Z

Please remove the extra line.

iSazonov · 2017-04-11T12:51:42Z

Can we verify the exact value instead of $null?

Should this be:

$helpContent | Should Not BeNullOrEmpty

iSazonov · 2017-04-12T04:23:34Z

Please clarify - is "Module" hardcoded for searching help files? And do this folder always exist? Maybe we should New-Item for it too?

TravisEz13 · 2017-04-12T18:58:27Z

I restarted MacOS because it appeared to have an issue downloading dotnet cli

SteveL-MSFT · 2017-04-18T23:08:25Z

@chunqingchen please verify this also addresses #2649

adityapatwardhan · 2017-04-19T23:21:20Z

Should be as follows to avoid output on console.

$null = New-Item -ItemType Directory -Path "$PSHOME\en-US" -ErrorAction SilentlyContinue

adityapatwardhan · 2017-04-19T23:21:38Z

Same as above.

adityapatwardhan · 2017-04-19T23:24:12Z

Should this be:

$helpContent | Should Not BeNullOrEmpty

chunqingchen · 2017-04-20T01:16:09Z

@adityapatwardhan your comments are resolved

Francisco-Gamino · 2017-04-20T15:39:41Z

Is this test case only meant to run on en-US? If it is, then you should skip it for non-English runs. Otherwise, please use (get-uiculture).Name.

Francisco-Gamino · 2017-04-20T15:40:38Z

This check should probably be $helpContent | Should Match "about_test"

chunqingchen · 2017-04-20T21:29:18Z

@Francisco-Gamino thanks, your comments are resolved

Francisco-Gamino · 2017-04-21T00:30:35Z

Also, does this tests run on Linux? If it does, then please use Join-Path instead of "$path\value"
E.g.,
$helpContentPath = join-path $PSHOME $culture
if (-not (test-path $helpContentPath))
{
}

chunqingchen · 2017-04-25T01:39:53Z

@Francisco-Gamino thanks, your comment is resolved !

mirichmo · 2017-04-26T01:00:07Z

@Francisco-Gamino && @adityapatwardhan Do you guys have any more concerns or is this ready for merge?

Francisco-Gamino

Please update this path $modulePath\en-US to $modulePath(get-uiculture).name. Other than that, it looks good. Thanks.

Francisco-Gamino · 2017-05-01T20:12:59Z

+Describe "Validate about_help.txt under culture specific folder works" -Tags @('CI') {
+    BeforeAll {
+        $modulePath = "$pshome\Modules\Test"
+        $null = New-Item -Path $modulePath\en-US -ItemType Directory -Force


This path should be $modulePath(get-culture).name

adityapatwardhan · 2017-05-01T20:23:04Z

@chunqingchen Changes approved.

chunqingchen · 2017-05-01T20:51:22Z

@Francisco-Gamino en-us is replaced with culture
@mirichmo please merge the change.

msftclas added the cla-not-required label Apr 11, 2017

iSazonov reviewed Apr 11, 2017

View reviewed changes

iSazonov reviewed Apr 12, 2017

View reviewed changes

daxian-dbw requested a review from Francisco-Gamino April 14, 2017 21:58

daxian-dbw assigned mirichmo Apr 14, 2017

SteveL-MSFT requested a review from adityapatwardhan April 18, 2017 22:59

adityapatwardhan requested changes Apr 19, 2017

View reviewed changes

Francisco-Gamino suggested changes Apr 20, 2017

View reviewed changes

Francisco-Gamino suggested changes Apr 21, 2017

View reviewed changes

chunqingchen added 2 commits April 24, 2017 16:13

Get-Help should find help files under pshome

4d5d223

Merge branch 'master' into bugfix3

407b2b0

SteveL-MSFT added this to the 6.0.0-beta1 milestone May 1, 2017

Francisco-Gamino approved these changes May 1, 2017

View reviewed changes

adityapatwardhan approved these changes May 1, 2017

View reviewed changes

mirichmo merged commit 5a82b10 into PowerShell:master May 1, 2017

SteveL-MSFT mentioned this pull request May 2, 2017

Get-Help does not list all 'About*' topics #2653

Closed

Conversation

chunqingchen commented Apr 11, 2017 • edited by joeyaiello Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iSazonov Apr 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TravisEz13 commented Apr 12, 2017

Uh oh!

SteveL-MSFT commented Apr 18, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunqingchen commented Apr 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunqingchen commented Apr 20, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chunqingchen commented Apr 25, 2017

Uh oh!

mirichmo commented Apr 26, 2017

Uh oh!

Francisco-Gamino left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adityapatwardhan commented May 1, 2017

Uh oh!

chunqingchen commented May 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

chunqingchen commented Apr 11, 2017 •

edited by joeyaiello

Loading

iSazonov Apr 12, 2017 •

edited

Loading