Update Copyright notice to remove year by kwiknick · Pull Request #3204 · PowerShell/PowerShell

kwiknick · 2017-02-26T05:07:18Z

This change is to fix Issue #3148 - Update copyright notices.
Changed the ManagedEntranceStrings resource file to take in a parameter. Then edited the ManagedEntrance.cs to grab the year using GetDate.Now and placing it in the banner variable for display when powershell is opened.

This change is to fix Issue #3148 - Update copywrite notices.

iSazonov · 2017-02-26T12:32:51Z

                    RunspaceConfigForSingleShell.Create(consoleFilePath, out warning);
            }
            int exitCode = 0;
+            string systemYear = DateTime.Now.Year.ToString();


Do we really need this variable if it is used only in one place?

I pulled it into a local variable because it's being used on line 113 and 115.

Maybe I was not accurate. This variable is under the #if directive and actually used once in the result code.

lzybkr · 2017-02-26T16:16:27Z

Maybe we don't even need the year, that would be even simpler.

kwiknick · 2017-02-26T17:22:38Z

I can change it to not have a year, but I was trying to fulfill what was asked in Issue #3148. There are no concerns of legal implications if the date isn't in there?

…

________________________________ From: Jason Shirk <notifications@github.com> Sent: Sunday, February 26, 2017 10:16 AM To: PowerShell/PowerShell Cc: Nicholas Willard; Author Subject: Re: [PowerShell/PowerShell] Add dynamic year for managed entrance message. (#3204) Maybe we don't even need the year, that would be even simpler. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3204 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AKg2vk1VPO9t9E_ME6YzRrOvu-t4aScYks5rgaVkgaJpZM4MMPrI>.

iSazonov · 2017-02-26T17:55:41Z

Currently all MSFT applications use a year in copyright (cmd.exe, notepad.exe, skype...)

lzybkr · 2017-02-26T19:34:59Z

We can follow up, but it might just be a historical thing, or copying a pattern. There was a move to remove the copyright year from source files at one point.

iSazonov · 2017-02-26T19:48:56Z

It seems that this (year) is tied to the main release time. I agree that is internal MSFT pattern. Perhaps it has historical legal roots.

andyleejordan · 2017-02-27T23:10:17Z

Aye, we need @joeyaiello and @SteveL-MSFT to weigh in on the legal question.

SteveL-MSFT · 2017-02-28T21:11:25Z

I'll follow up on this.

kwiknick · 2017-03-01T02:58:00Z

Thanks for all the comments and feedback. I out of habit brought my fork up to upstream/master, which, as it's supposed to, kicked off the CI builds. I didn't change any of the code I submitted. I'm just big on keeping my branch, fork in this case, up to date in order to limit merge conflicts.

SteveL-MSFT

Waiting on legal

joeyaiello · 2017-03-01T17:48:28Z

Just so I understand, is the date dynamically generated at build time or runtime? If I had to guess, I think runtime is probably problematic, but that's just a hunch.

Either way, I'm sending off the mail to legal now

SteveL-MSFT · 2017-03-01T18:00:58Z

@joeyaiello I've already started a conversation with legal

kwiknick · 2017-03-01T18:15:50Z

@joeyaiello It is generated at runtime, which I can see how/why It'd be problematic. If legal decides that they want the date, I'll get it to generate at build time. I should've done that in the first place.

daxian-dbw · 2017-03-02T19:27:59Z

Just found that dotnet publish with the RC4 dotnet CLI doesn't have the year in coryright banner now:

PS:53> dotnet publish -f netcoreapp1.0 -c release
Microsoft (R) Build Engine version 15.1.545.13942
Copyright (C) Microsoft Corporation. All rights reserved.

  console -> X:\arena\apps\console\bin\release\netcoreapp1.0\console.dll

powershell should go this direction too.

joeyaiello · 2017-03-02T21:30:17Z

We'll ask if that's an option to legal as well

iSazonov · 2017-03-03T03:58:42Z

For legal too: What copyright we should use in the files? These files have been published under MIT. There are also new files.

SteveL-MSFT

We are approved to just use:

kwiknick · 2017-03-03T17:20:28Z

@SteveL-MSFT That's great news! I'll update it this evening and push the changes. Thanks everyone for all the collaboration.

Fixes Issue #3148

kwiknick · 2017-03-04T16:00:56Z

@SteveL-MSFT the changes have been made and this is ready for review. Thanks for being so helpful.

iSazonov · 2017-03-04T16:34:45Z

+                var banner = string.Format(ManagedEntranceStrings.ShellBannerNonWindowsPowerShell);
 #else
-                var banner = ManagedEntranceStrings.ShellBanner;
+                var banner = string.Format(ManagedEntranceStrings.ShellBanner);


string.Format - It seems should be removed.

And why we use Core and non-Core banner?

kwiknick · 2017-03-04T17:01:24Z

@SteveL-MSFT Thanks for catching the unnecessary string.Formats. I forgot to remove them as well a couple using statements. The way I read the code when I first forked it, was that it shows a different banner based on the OS of the machine. Do you want me to remove that as well and just have it to be the same message regardless?

iSazonov · 2017-03-04T17:41:49Z

I remember that @lzybkr open PR to remove Windows PowerShell from the repo so I believe we should remove the non-Core banner.

SteveL-MSFT · 2017-03-04T19:53:40Z

@iSazonov I believe that PR is to just stop building Windows PowerShell. I would leave the non-Core banner for now.

iSazonov · 2017-03-04T20:50:06Z

I agree.

msftclas · 2017-03-04T21:19:02Z

@kwiknick,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

kwiknick · 2017-03-04T21:19:59Z

Closed and Reopened to kick off the cla bot.

Add dynamic year for managed entrance message.

10fb87c

This change is to fix Issue #3148 - Update copywrite notices.

iSazonov reviewed Feb 26, 2017

View reviewed changes

daxian-dbw assigned mirichmo Feb 26, 2017

SteveL-MSFT self-requested a review February 28, 2017 21:11

Merge remote-tracking branch 'upstream/master'

b32e380

SteveL-MSFT requested changes Mar 1, 2017

View reviewed changes

SteveL-MSFT requested changes Mar 3, 2017

View reviewed changes

kwiknick added 2 commits March 4, 2017 09:18

Merge remote-tracking branch 'upstream/master'

549c723

Update Copyright notices to not have a Date.

4c18831

Fixes Issue #3148

iSazonov reviewed Mar 4, 2017

View reviewed changes

Remove unnecessary string.Formats in the ManagedStrings.cs

93ecd70

SteveL-MSFT approved these changes Mar 4, 2017

View reviewed changes

kwiknick closed this Mar 4, 2017

kwiknick reopened this Mar 4, 2017

msftclas added the cla-already-signed label Mar 4, 2017

SteveL-MSFT changed the title ~~Add dynamic year for managed entrance message.~~ Update Copyright notice to remove year Mar 5, 2017

lzybkr approved these changes Mar 5, 2017

View reviewed changes

lzybkr merged commit df0a390 into PowerShell:master Mar 5, 2017

Conversation

kwiknick commented Feb 26, 2017

Uh oh!

iSazonov Feb 26, 2017

Choose a reason for hiding this comment

Uh oh!

kwiknick Feb 26, 2017

Choose a reason for hiding this comment

Uh oh!

iSazonov Feb 26, 2017

Choose a reason for hiding this comment

Uh oh!

lzybkr commented Feb 26, 2017

Uh oh!

kwiknick commented Feb 26, 2017 via email

Uh oh!

iSazonov commented Feb 26, 2017

Uh oh!

lzybkr commented Feb 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iSazonov commented Feb 26, 2017

Uh oh!

andyleejordan commented Feb 27, 2017

Uh oh!

SteveL-MSFT commented Feb 28, 2017

Uh oh!

kwiknick commented Mar 1, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveL-MSFT left a comment

Choose a reason for hiding this comment

Uh oh!

joeyaiello commented Mar 1, 2017

Uh oh!

SteveL-MSFT commented Mar 1, 2017

Uh oh!

kwiknick commented Mar 1, 2017

Uh oh!

daxian-dbw commented Mar 2, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joeyaiello commented Mar 2, 2017

Uh oh!

iSazonov commented Mar 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SteveL-MSFT left a comment

Choose a reason for hiding this comment

Uh oh!

kwiknick commented Mar 3, 2017

Uh oh!

kwiknick commented Mar 4, 2017

Uh oh!

iSazonov Mar 4, 2017

Choose a reason for hiding this comment

Uh oh!

kwiknick commented Mar 4, 2017

Uh oh!

iSazonov commented Mar 4, 2017

Uh oh!

SteveL-MSFT commented Mar 4, 2017

Uh oh!

iSazonov commented Mar 4, 2017

Uh oh!

msftclas commented Mar 4, 2017

Uh oh!

kwiknick commented Mar 4, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

lzybkr commented Feb 26, 2017 •

edited

Loading

kwiknick commented Mar 1, 2017 •

edited

Loading

daxian-dbw commented Mar 2, 2017 •

edited

Loading

iSazonov commented Mar 3, 2017 •

edited

Loading