Fix for race bug in WSMan command plugin instance close operation#3203
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Feb 27, 2017
PaulHigin:RaceFix
Merged
Fix for race bug in WSMan command plugin instance close operation#3203daxian-dbw merged 1 commit intoPowerShell:masterfrom PaulHigin:RaceFix
daxian-dbw merged 1 commit intoPowerShell:masterfrom
PaulHigin:RaceFix
Conversation
dantraMSFT
approved these changes
Feb 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a rare race condition that can crash the WinRM service when remote sessions are closing.
From the crash stack dump it is clear that the exception comes from a SetThreadProperties call that references an invalid unmanaged data handle which was previously released. The data handle is released when the plugin command instance is closed and the error occurs when two threads contend to close the same object.
The close command and close session operations are designed to be multi-thread safe, but the SetThreadProperties call is done before the atomic check is performed. The fix is to move the SetThreadProperties call after the atomic check to ensure it is only called when the object is in the opened state.