Avoid calling credential provider for public feed for Wix - #27663
Merged
Conversation
Aditya Patwardhan (adityapatwardhan)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
July 7, 2026 21:08
Copilot started reviewing on behalf of
Aditya Patwardhan (adityapatwardhan)
July 7, 2026 21:08
View session
Travis Plunk (TravisEz13)
approved these changes
Jul 7, 2026
Travis Plunk (TravisEz13)
enabled auto-merge (squash)
July 7, 2026 21:10
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the WiX installation helper (Install-Wix) to further configure the dotnet-eng PSResourceGet repository so that the public Azure DevOps feed doesn’t trigger credential-provider behavior.
Changes:
- After registering
dotnet-eng, set the repository’s credential provider toNone. - (Suggested) Improve robustness by handling environments where an older
Microsoft.PowerShell.PSResourceGetis installed and may not support-CredentialProvider.
Comment on lines
45
to
47
| $respository = Get-PSResourceRepository -Name 'dotnet-eng' -ErrorAction SilentlyContinue | ||
|
|
||
| if (-not $respository) { |
| if (-not $respository) { | ||
| Write-Verbose -Verbose "Registering dotnet-eng repository..." | ||
| Register-PSResourceRepository -Name 'dotnet-eng' -Uri 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json' -Trusted | ||
| Set-PSResourceRepository -CredentialProvider None -Name 'dotnet-eng' -Trusted |
9 tasks
9 tasks
9 tasks
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This pull request makes a minor update to the
Install-Wixfunction inwix.psm1to further configure thedotnet-engrepository after registering it.dotnet-engrepository, the script now sets its credential provider toNoneto ensure no credentials are required for access.PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright header