PMC release: Use slash instead of back-slash for Linux container#27315
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Apr 21, 2026
Merged
PMC release: Use slash instead of back-slash for Linux container#27315daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
jshigetomi
approved these changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the EV2 release prep pipeline template to use POSIX-style paths so CredScan can locate the suppression file when running in a Linux container.
Changes:
- Switch
ob_sdl_credscan_suppressionsFilefrom Windows\separators to/separators for Linux execution.
| - group: 'packages.microsoft.com' | ||
| - name: ob_sdl_credscan_suppressionsFile | ||
| value: $(Build.SourcesDirectory)\PowerShell\.config\suppress.json | ||
| value: $(Build.SourcesDirectory)/PowerShell/.config/suppress.json |
There was a problem hiding this comment.
Consider reusing the already-defined repoRoot variable here (e.g., $(repoRoot)/.config/suppress.json) instead of repeating $(Build.SourcesDirectory)/PowerShell. This reduces duplication and prevents future path changes from requiring multiple updates.
Suggested change
| value: $(Build.SourcesDirectory)/PowerShell/.config/suppress.json | |
| value: $(repoRoot)/.config/suppress.json |
adityapatwardhan
approved these changes
Apr 21, 2026
9 tasks
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Use slash instead of back-slash for Linux container. Otherwise, the
CreadScanstep fails because it cannot find the file.