Skip to content

Remove package verification from the notice pipeline#27289

Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw:notice-yml
Apr 17, 2026
Merged

Remove package verification from the notice pipeline#27289
daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw:notice-yml

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw commented Apr 16, 2026

PR Summary

Now that the "Release Prep" workflow does the work to update cgmanifest.json, we should remove package verification from the notice pipeline.

@daxian-dbw daxian-dbw requested review from a team and jshigetomi as code owners April 16, 2026 23:55
Copilot AI review requested due to automatic review settings April 16, 2026 23:55
@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 16, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes local package-license verification/harvesting from the notice generation pipeline and deletes the in-repo clearlyDefined tooling now intended to live in the Infrastructure repo, aligning notice generation with the updated “Release Prep” ownership of cgmanifest.json.

Changes:

  • Delete tools/findMissingNotices.ps1 (previously used to rebuild/update cgmanifest.json/TPN-related manifests).
  • Remove the clearlyDefined tool/module/scripts from tools/clearlyDefined/.
  • Simplify the notice pipeline by removing the “Verify that packages have license data” step and the related SkipVerifyPackages parameter.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/findMissingNotices.ps1 Removed the script previously used to rebuild/update component governance manifests.
tools/clearlyDefined/src/ClearlyDefined/ClearlyDefined.psm1 Removed the ClearlyDefined PowerShell module implementation from this repo.
tools/clearlyDefined/readme.md Removed documentation for the in-repo ClearlyDefined tooling.
tools/clearlyDefined/Find-LastHarvestedVersion.ps1 Removed helper used for harvested-version fallback logic.
tools/clearlyDefined/ClearlyDefined.ps1 Removed the entrypoint script for testing/harvesting ClearlyDefined data.
.pipelines/templates/compliance/generateNotice.yml Removed the package license-data verification step and the SkipVerifyPackages parameter.
.pipelines/apiscan-gen-notice.yml Removed the SkipVerifyPackages pipeline parameter passthrough to the notice template.

@daxian-dbw daxian-dbw changed the title Remove package verification from the notice pipeline and move the 'clearlyDefined' tool to the Infrastructure repo Remove package verification from the notice pipeline Apr 16, 2026
@daxian-dbw daxian-dbw merged commit 558c886 into PowerShell:master Apr 17, 2026
37 checks passed
@daxian-dbw daxian-dbw deleted the notice-yml branch April 17, 2026 17:05
Copy link
Copy Markdown
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.4.x-Consider Backport-7.5.x-Consider Backport-7.6.x-Consider CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants