add a timeout to test-connection#2492
add a timeout to test-connection#2492lzybkr merged 1 commit intoPowerShell:masterfrom jpsnover:jpsnover/Test-ComputerTimeOut
Conversation
|
Hi @jpsnover, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
jeffrey and I spoke about my comments - the current timeout is 1000 ms, so this does not change our current behavior and provides for more flexibility |
There was a problem hiding this comment.
this comment does not seem to apply
|
I'd love to see additional tests here - something along those lines |
|
Your committer email (private@jsnover.com) appears to be connected to the @jsnover GitHub account, and not the @jpsnover GitHub account you opened the PR from (so the commit doesn't "belong" to @jpsnover as far as GitHub is concerned). Do you mean to use this email for you commits, and if so, is it possible to verify it with your current @jpsnover GitHub account? |
|
@andschwa I've made it so hat private@jsnover.com is the only account connected to my jpsnover github account. |
| /// The following is the definition of the input parameter "TimeOut". | ||
| /// Time-out value in milliseconds. If a response is not received in this time, no response is assumed. The default is 1000 milliseconds. | ||
| /// </summary> | ||
| [Parameter] |
There was a problem hiding this comment.
I've never liked this use of ValidateRange - it seems like we should have ValidatePositive and ValidateNonNegative attributes.
This replaces PR #2479