Skip to content

Add ability to capture MSBuild Binary logs when restore fails - #24128

Merged
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
TravisEz13:add_capture_binlogs
Aug 9, 2024
Merged

Add ability to capture MSBuild Binary logs when restore fails#24128
Travis Plunk (TravisEz13) merged 2 commits into
PowerShell:masterfrom
TravisEz13:add_capture_binlogs

Conversation

@TravisEz13

@TravisEz13 Travis Plunk (TravisEz13) commented Aug 8, 2024

Copy link
Copy Markdown
Member

PR Summary

This pull request introduces changes to enable MSBuild binary logging and improve the handling of build artifacts in the pipeline configuration and build scripts.

Pipeline Configuration Changes:

Build Script Enhancements:

  • build.psm1: Modified the Restore-PSPackage function to append the -bl argument for binary logging if ENABLE_MSBUILD_BINLOGS is set.
  • build.psm1: Enhanced the Restore-PSPackage function to handle and upload MSBuild binary logs if a restore operation fails and ENABLE_MSBUILD_BINLOGS is enabled.

PR Context

Binary logs are much more readable but are too big to use all the time.

PR Checklist

@TravisEz13 Travis Plunk (TravisEz13) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 8, 2024
Comment thread .pipelines/PowerShell-Coordinated_Packages-Official.yml Outdated
@TravisEz13
Travis Plunk (TravisEz13) merged commit 345707c into PowerShell:master Aug 9, 2024
@TravisEz13
Travis Plunk (TravisEz13) deleted the add_capture_binlogs branch August 9, 2024 17:23
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Aug 9, 2024

Copy link
Copy Markdown
Contributor

📣 Hey Travis Plunk (@TravisEz13), how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Chris Dent (chrisdent-de) pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024
…hell#24128)

* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
Travis Plunk (TravisEz13) added a commit to TravisEz13/PowerShell that referenced this pull request Oct 11, 2024
…hell#24128)

* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
Aditya Patwardhan (adityapatwardhan) pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 16, 2024
…hell#24128)

* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
Travis Plunk (TravisEz13) added a commit that referenced this pull request Jan 16, 2025
* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
Travis Plunk (TravisEz13) added a commit that referenced this pull request Jan 16, 2025
#24799)

* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
…hell#24128)

* Capture binary logs

* Update .pipelines/PowerShell-Coordinated_Packages-Official.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.2.x-Done Backport-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants