Update to .NET 8 Preview 4#19696
Conversation
daxian-dbw
left a comment
There was a problem hiding this comment.
There are protected constructors removed like the following 2. Should them be kept with an obsolete attribute? I didn't try finding all the places with this same issue, so please go over your changes and see if there are more instances of this.
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
@adityapatwardhan Please fix the CI failures. |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
daxian-dbw
left a comment
There was a problem hiding this comment.
LGTM. Thanks @adityapatwardhan!
|
🎉 Handy links: |
PR Summary
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).