Fix CompleteInput error for empty scripts#19501
Fix CompleteInput error for empty scripts#19501daxian-dbw merged 2 commits intoPowerShell:masterfrom
Conversation
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
daxian-dbw
left a comment
There was a problem hiding this comment.
I think we should return s_emptyCommandCompletion early in CompletInput overloads in case the passed-in script is an empty string or the passed-in AST has ast.Extent.Text being an empty string.
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
PR Summary
Fixes a crash when attempting to tab complete an empty script.
PR Context
Fixes #5743
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).