Webcmdlets Encoding.RegisterProvider(CodePagesEncodingProvider.Instance)#18711
Closed
CarloToso wants to merge 1 commit intoPowerShell:masterfrom
Closed
Webcmdlets Encoding.RegisterProvider(CodePagesEncodingProvider.Instance)#18711CarloToso wants to merge 1 commit intoPowerShell:masterfrom
CarloToso wants to merge 1 commit intoPowerShell:masterfrom
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Collaborator
|
I guess #18605 will fix the issue. Yes? |
Contributor
Author
I will test it as soon as possible, and then close this PR if it does |
Contributor
Author
|
#18605 will fix the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix support for exotic text encodings in Webcmdlets
(I need some advice on the best place to add
Encoding.RegisterProvider(CodePagesEncodingProvider.Instance))PR Context
Anytime we use
Encoding.GetEncoding()we have to useEncoding.RegisterProvider(CodePagesEncodingProvider.Instance)to account for all the exotic charsets (at the moment we consider only: ASCII, ISO-8859-1, UTF-7, UTF-8, UTF-16, UTF-32)Fixes #18677
Test:
Invoke-WebRequest "https://www.ukrlib.com.ua/"(This website uses the windows-1251 encoding, it was not supported even if it was correctly identified by the
s_metaexpRegex inStreamHelper.cs)https://learn.microsoft.com/en-us/dotnet/api/system.text.codepagesencodingprovider?source=recommendations&view=net-7.0