Skip to content

Change exec from alias to function to handle arbitrary args#18567

Merged
daxian-dbw merged 6 commits intoPowerShell:masterfrom
SteveL-MSFT:exec-function
Nov 17, 2022
Merged

Change exec from alias to function to handle arbitrary args#18567
daxian-dbw merged 6 commits intoPowerShell:masterfrom
SteveL-MSFT:exec-function

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Nov 15, 2022 •
edited
Loading

PR Summary

Previously exec was an alias to switch-process. The problem is if you use exec with args that contain something like -w which PowerShell tries to bind to -WithCommand (parameter for Switch-Process) then the other args try to get bound to positional parameters which do not exist. So something like exec /bin/echo 1 -w 2 fails whereas it should simply replace the current pwsh with echo and emit "1 -w 2".

The fix is to change from an alias to a function so that all the args get passed to Switch-Parameter by using -WithCommand explicitly so the remaining args get handled correctly.

PR Context

Fix #18561

PR Checklist

@ghost ghost assigned TravisEz13 Nov 15, 2022
daxian-dbw
daxian-dbw approved these changes Nov 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw closed this Nov 15, 2022
@daxian-dbw daxian-dbw reopened this Nov 15, 2022
SteveL-MSFT
SteveL-MSFT commented Nov 15, 2022
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Exec.Tests.ps1 Outdated
daxian-dbw
daxian-dbw approved these changes Nov 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/System.Management.Automation/engine/InitialSessionState.cs Outdated
iSazonov
iSazonov reviewed Nov 16, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/InitialSessionState.cs
@sdwheeler sdwheeler mentioned this pull request Nov 16, 2022
Closed
3 tasks
kilasuit
kilasuit suggested changes Nov 17, 2022
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Core/Exec.Tests.ps1 Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 17, 2022
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated Bot commented Nov 17, 2022

This PR has 24 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +16 -8
Percentile : 9.6%

Total files changed: 3

Change summary by file extension:
.cs : +9 -3
.ps1 : +7 -5

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 17, 2022
@daxian-dbw daxian-dbw merged commit 9ae18ab into PowerShell:master Nov 17, 2022
@daxian-dbw daxian-dbw added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Nov 17, 2022
@SteveL-MSFT SteveL-MSFT deleted the exec-function branch November 17, 2022 21:35
@iSazonov iSazonov mentioned this pull request Nov 18, 2022
Merged
13 tasks
@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Nov 22, 2022

/backport to release/v7.3.1

@github-actions github-actions Bot mentioned this pull request Nov 22, 2022
Merged
1 task
@paulhey paulhey mentioned this pull request Dec 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov iSazonov approved these changes

@JamesWTruher JamesWTruher Awaiting requested review from JamesWTruher

+1 more reviewer

@kilasuit kilasuit kilasuit requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

Backport-7.3.x-Done CL-Engine Indicates that a PR should be marked as an engine change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ssh command can't spawn a proxy command via "exec" from a pwsh 7.3.0 session

5 participants

@SteveL-MSFT @daxian-dbw @kilasuit @iSazonov @TravisEz13