Skip to content

Make experimental feature PSRemotingSSHTransportErrorHandling stable#18046

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
SteveL-MSFT:PSRemotingSSHTransportErrorHandling-stable
Sep 8, 2022
Merged

Make experimental feature PSRemotingSSHTransportErrorHandling stable#18046
daxian-dbw merged 2 commits intoPowerShell:masterfrom
SteveL-MSFT:PSRemotingSSHTransportErrorHandling-stable

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

@SteveL-MSFT SteveL-MSFT commented Sep 6, 2022 •
edited
Loading

PR Summary

PS-Committee reviewed this and this addresses a major issue with SSH remoting where native command use stderr as information and not an error which previously would kill the connection, so we want to take this fix

PR Context

Per #17962 make stable

PR Checklist

@ghost ghost assigned anmenaga Sep 6, 2022
PaulHigin
PaulHigin suggested changes Sep 7, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/fanin/OutOfProcTransportManager.cs Outdated
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Sep 7, 2022
@SteveL-MSFT SteveL-MSFT force-pushed the PSRemotingSSHTransportErrorHandling-stable branch from 42992bb to 85c7e15 Compare September 7, 2022 21:37
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated Bot commented Sep 7, 2022

This PR has 49 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +6 -43
Percentile : 19.6%

Total files changed: 4

Change summary by file extension:
.json : +0 -2
.cs : +6 -41

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@daxian-dbw daxian-dbw added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Sep 8, 2022
@daxian-dbw daxian-dbw merged commit 3bf6423 into PowerShell:master Sep 8, 2022
@SteveL-MSFT SteveL-MSFT deleted the PSRemotingSSHTransportErrorHandling-stable branch September 8, 2022 19:00
@adityapatwardhan
Copy link
Copy Markdown
Member

adityapatwardhan commented Sep 12, 2022

/backport to release/v7.3.0-rc.1

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 12, 2022

@adityapatwardhan backporting to release/v7.3.0-rc.1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: fix merge conflict
Using index info to reconstruct a base tree...
M	experimental-feature-linux.json
M	experimental-feature-windows.json
M	src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Falling back to patching base and 3-way merge...
Auto-merging src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
CONFLICT (content): Merge conflict in src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Auto-merging experimental-feature-windows.json
Auto-merging experimental-feature-linux.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix merge conflict
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Sep 14, 2022
@SteveL-MSFT @adityapatwardhan
Make experimental feature PSRemotingSSHTransportErrorHandling stable (
44d9e5d 
PowerShell#18046)
@adityapatwardhan adityapatwardhan mentioned this pull request Sep 14, 2022
Merged
22 tasks
adityapatwardhan added a commit that referenced this pull request Sep 14, 2022
@adityapatwardhan
Make experimental feature PSRemotingSSHTransportErrorHandling stable (
ec7bb20 
#18046) (#18085)
@ghost
Copy link
Copy Markdown

ghost commented Sep 20, 2022

🎉v7.3.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

@michaeltlombardi michaeltlombardi mentioned this pull request Sep 21, 2022
Closed
2 tasks
@jazzdelightsme
Copy link
Copy Markdown
Contributor

jazzdelightsme commented Sep 26, 2022

@SteveL-MSFT : will this be documented? I can't find any, and I don't know what this is, but it sounds interesting.

@daxian-dbw
Copy link
Copy Markdown
Member

daxian-dbw commented Sep 26, 2022

@jazzdelightsme See #16205 for the description of the change.
It's more of a bug fix because stderr stream could contain non-error messages.

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

+1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

Backport-7.3.x-Done CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SteveL-MSFT @adityapatwardhan @jazzdelightsme @daxian-dbw @PaulHigin @iSazonov @anmenaga