Use null propagation operator for windows build#17795
Merged
PaulHigin merged 7 commits intoPowerShell:masterfrom Jul 29, 2022
Merged
Use null propagation operator for windows build#17795PaulHigin merged 7 commits intoPowerShell:masterfrom
PaulHigin merged 7 commits intoPowerShell:masterfrom
Conversation
Contributor
Author
|
Don't have a Windows-machine to build on atm. but hopefully I caught most of them. @iSazonov Any tips regarding 31408eb ? Update: Never mind. |
PaulHigin
suggested changes
Jul 28, 2022
fflaten
commented
Jul 28, 2022
iSazonov
approved these changes
Jul 29, 2022
| { | ||
| securityDescHandle.Value.Free(); | ||
| } | ||
| securityDescHandle?.Free(); |
Collaborator
22 tasks
|
🎉 Handy links: |
22 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Replace if not null-checks with null propagation operator to solve IDE0031 with .NET Preview 7.
Additional findings when compiled against win7-x64 (in devcontainer).
PR Context
Related to #17769
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).