Fix the definition of the PDH_COUNTER_INFO struct#17779
Merged
PaulHigin merged 2 commits intoPowerShell:masterfrom Jul 27, 2022
Merged
Fix the definition of the PDH_COUNTER_INFO struct#17779PaulHigin merged 2 commits intoPowerShell:masterfrom
PDH_COUNTER_INFO struct#17779PaulHigin merged 2 commits intoPowerShell:masterfrom
Conversation
22 tasks
Member
|
@SeeminglyScience please fix the CodeFactor issue if they were introduced in this PR: https://www.codefactor.io/repository/github/powershell/powershell/pull/17779
|
Member
|
@SeeminglyScience can you validate the change on x86 and arm64? We do not run CI on those platforms. |
Contributor
Author
Tested in x86, looks good. |
Contributor
Author
|
@adityapatwardhan Verified with Steve that |
adityapatwardhan
approved these changes
Jul 27, 2022
|
🎉 Handy links: |
22 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes the crash from #13829
PR Context
The definition is mostly generated via dotnet/ClangSharp and altered a little manually. It's a bit involved for a struct we only use two fields from but it's easy to include in full so if we end up needing more this makes it very easy.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).