Skip to content

Enable Dependabot for GitHub Actions#17775

Merged
daxian-dbw merged 2 commits intoPowerShell:masterfrom
Molkree:dependabot-gh-actions
Aug 3, 2022
Merged

Enable Dependabot for GitHub Actions#17775
daxian-dbw merged 2 commits intoPowerShell:masterfrom
Molkree:dependabot-gh-actions

Conversation

@Molkree
Copy link
Copy Markdown
Contributor

@Molkree Molkree commented Jul 26, 2022

PR Summary

Enable Dependabot for GitHub Actions.

PR Context

This repository already uses Dependabot but not for GitHub Actions used in workflows.

I see some old (major) versions used in various workflows, with CodeQL v1 being probably the most important one because it will be deprecated in December.
https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/

Fixes #17743

PR Checklist

@ghost ghost added the Review - Needed The PR is being reviewed label Aug 2, 2022
@ghost
Copy link
Copy Markdown

ghost commented Aug 2, 2022

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Comment thread .github/dependabot.yml
Comment thread .github/dependabot.yml
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Review - Needed The PR is being reviewed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Aug 3, 2022
Co-authored-by: Dongbo Wang <dongbow@microsoft.com>
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

This PR has 6 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Extra Small
Size       : +6 -0
Percentile : 2.4%

Total files changed: 1

Change summary by file extension:
.yml : +6 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@Molkree Molkree requested a review from daxian-dbw August 3, 2022 11:57
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Aug 3, 2022
@daxian-dbw daxian-dbw merged commit b618f45 into PowerShell:master Aug 3, 2022
@Molkree Molkree deleted the dependabot-gh-actions branch August 3, 2022 16:40
@ghost
Copy link
Copy Markdown

ghost commented Aug 11, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 11, 2022
@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Extra Small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Dependabot for GitHub Actions

3 participants