Skip to content

Use null-coalescing assignment in the rest of /engine#17729

Merged
daxian-dbw merged 4 commits intoPowerShell:masterfrom
Molkree:fix_IDE0074_engine_etc
Jul 26, 2022
Merged

Use null-coalescing assignment in the rest of /engine#17729
daxian-dbw merged 4 commits intoPowerShell:masterfrom
Molkree:fix_IDE0074_engine_etc

Conversation

@Molkree
Copy link
Copy Markdown
Contributor

@Molkree Molkree commented Jul 20, 2022

PR Summary

Use compound assignment in the rest of /engine

PR Context

Part of #17631.

PR Checklist

@ghost ghost assigned anmenaga Jul 20, 2022
@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 21, 2022
@iSazonov
Copy link
Copy Markdown
Collaborator

@daxian-dbw Should we keep ComInterop folder unchanged?

@daxian-dbw
Copy link
Copy Markdown
Member

I'm fine making this code style change in this folder given there aren't too many changes. Still, need to be carefully reviewed.

@SteveL-MSFT SteveL-MSFT changed the title Use compound assignment in the rest of /engine Use null-coalescing assignment in the rest of /engine Jul 25, 2022
Comment thread src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 25, 2022
Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs Outdated
Comment thread src/System.Management.Automation/engine/Modules/NewModuleManifestCommand.cs Outdated
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jul 26, 2022
Co-authored-by: Steve Lee <slee@microsoft.com>
Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs Outdated
@iSazonov iSazonov assigned daxian-dbw and unassigned anmenaga Jul 26, 2022
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 1779175 into PowerShell:master Jul 26, 2022
@daxian-dbw
Copy link
Copy Markdown
Member

Thanks @Molkree for your contribution!

@Molkree Molkree deleted the fix_IDE0074_engine_etc branch July 26, 2022 20:05
@ghost
Copy link
Copy Markdown

ghost commented Aug 11, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants