Skip to content

Improve dynamic parameter tab completion#17661

Merged
daxian-dbw merged 5 commits intoPowerShell:masterfrom
MartinGC94:ImproveDynamicParamTabCompletion
Jul 18, 2022
Merged

Improve dynamic parameter tab completion#17661
daxian-dbw merged 5 commits intoPowerShell:masterfrom
MartinGC94:ImproveDynamicParamTabCompletion

Conversation

@MartinGC94
Copy link
Copy Markdown
Contributor

@MartinGC94 MartinGC94 commented Jul 10, 2022 •
edited by daxian-dbw
Loading

PR Summary

Fixes #9983
Fixes #3189
Fixes #5326
This makes the pseudo parameter binder use the expression value if it's a constant expression rather than the raw Ast text. This removes the need for special handling by dynamic parameters for "quoted" VS. "unquoted" strings.
Get-ChildItem did not handle this properly so this: Get-ChildItem -Path "C:\" -<Tab> wouldn't show the filesystem provider parameters but Get-ChildItem -Path C:\ -<Tab> would.

PR Context

PR Checklist

@ghost ghost assigned TravisEz13 Jul 10, 2022
iSazonov
iSazonov reviewed Jul 12, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs Outdated
iSazonov
iSazonov reviewed Jul 12, 2022
View reviewed changes
Comment thread test/powershell/Host/TabCompletion/TabCompletion.Tests.ps1
@MartinGC94 @iSazonov
Apply suggestions from code review
2145015 
Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
iSazonov reviewed Jul 13, 2022
View reviewed changes
Comment thread src/System.Management.Automation/engine/CommandCompletion/PseudoParameterBinder.cs Outdated
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Jul 14, 2022

@MartinGC94 Please look CI fails.

@MartinGC94
Copy link
Copy Markdown
Contributor Author

MartinGC94 commented Jul 14, 2022

The CI fails don't make any sense to me. My branch is 7 days old and the OrderedHashtable type was only added to the master branch yesterday, why is it running tests that depend on code changes that don't exist in my branch yet?
Anyway, I'll merge the latest master changes and see if that helps.

@MartinGC94 MartinGC94 closed this Jul 14, 2022
@MartinGC94 MartinGC94 reopened this Jul 14, 2022
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated Bot commented Jul 14, 2022

This PR has 28 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +21 -7
Percentile : 11.2%

Total files changed: 2

Change summary by file extension:
.cs : +14 -7
.ps1 : +7 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Jul 15, 2022

The CI fails don't make any sense to me. My branch is 7 days old and the OrderedHashtable type was only added to the master branch yesterday, why is it running tests that depend on code changes that don't exist in my branch yet? Anyway, I'll merge the latest master changes and see if that helps.

Look like a bug in CI workflow. Ping @TravisEz13 and @adityapatwardhan

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jul 15, 2022
@iSazonov iSazonov requested a review from daxian-dbw July 15, 2022 03:33
daxian-dbw
daxian-dbw approved these changes Jul 18, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw daxian-dbw merged commit 53adf5d into PowerShell:master Jul 18, 2022
@MartinGC94 MartinGC94 deleted the ImproveDynamicParamTabCompletion branch July 19, 2022 14:43
@ghost
Copy link
Copy Markdown

ghost commented Aug 11, 2022

🎉v7.3.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Aug 11, 2022
Closed
Closed
Closed
@TravisEz13 TravisEz13 mentioned this pull request Sep 30, 2022
Merged
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw daxian-dbw daxian-dbw approved these changes

@iSazonov iSazonov iSazonov approved these changes

Assignees

@TravisEz13 TravisEz13

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

4 participants

@MartinGC94 @iSazonov @daxian-dbw @TravisEz13