Render decimal numbers in a table using current culture#17650
Merged
anmenaga merged 14 commits intoPowerShell:masterfrom Jul 18, 2022
Merged
Render decimal numbers in a table using current culture#17650anmenaga merged 14 commits intoPowerShell:masterfrom
anmenaga merged 14 commits intoPowerShell:masterfrom
Conversation
SteveL-MSFT
commented
Jul 9, 2022
…ies/MshObjectUtil.cs
iSazonov
reviewed
Jul 9, 2022
…ble.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
…ble.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
…st.Tests.ps1 Co-authored-by: Ilya <darpa@yandex.ru>
…ies/MshObjectUtil.cs Co-authored-by: Ilya <darpa@yandex.ru>
…ies/MshObjectUtil.cs Co-authored-by: Ilya <darpa@yandex.ru>
…ies/MshObjectUtil.cs Co-authored-by: Ilya <darpa@yandex.ru>
…ViewGenerator_Table.cs Co-authored-by: Ilya <darpa@yandex.ru>
…ies/MshObjectUtil.cs Co-authored-by: Ilya <darpa@yandex.ru>
Collaborator
|
@SteveL-MSFT Please remove |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
iSazonov
approved these changes
Jul 14, 2022
PaulHigin
approved these changes
Jul 18, 2022
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Previously, decimal numbers are rendered in tables with all of the decimal places. This is not as useful in Tables where number alignment and minimal number of decimal places can provide more and easier to read information. The change here is only for
Format-Tablewhere decimal, float, and double values use the user's current culture set for NumberDecimalDigits is applied.Since this only affects formatting and not the actual value, this is not a breaking change.
PR Context
Fix #17544
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).
17544