Update .NET SDK version from 7.0.100-preview.5.22307.18 to 7.0.100-preview.6.22352.1#17634
Update .NET SDK version from 7.0.100-preview.5.22307.18 to 7.0.100-preview.6.22352.1#17634adityapatwardhan merged 4 commits intomasterfrom
7.0.100-preview.5.22307.18 to 7.0.100-preview.6.22352.1#17634Conversation
…-preview.6.22352.1`
7d2569d to
83922ce
Compare
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
| $res = [AstTypeInference]::InferTypeOf( { [io.fileinfo]::new("file") | Select-Object -ExcludeProperty *Time*, E* }.Ast) | ||
| $res.Count | Should -Be 1 | ||
| $res[0].Name | Should -BeExactly "System.Management.Automation.PSObject#Attributes:BaseName:Directory:DirectoryName:FullName:IsReadOnly:Length:LengthString:LinkTarget:LinkType:Mode:ModeWithoutHardLink:Name:NameString:ResolvedTarget:Target:VersionInfo" | ||
| $res[0].Name | Should -BeExactly "System.Management.Automation.PSObject#Attributes:BaseName:Directory:DirectoryName:FullName:IsReadOnly:Length:LengthString:LinkTarget:LinkType:Mode:ModeWithoutHardLink:Name:NameString:ResolvedTarget:Target:UnixFileMode:VersionInfo" |
There was a problem hiding this comment.
PowerShell has a UnixMode script property for FileInfo and DirectoryInfo on Unix platforms. I wonder if the new UnixFileMode would bring any issues for the existing script property ... like what if they are showing different results?
Can you check what is returned by UnixFileMode on Linux?
There was a problem hiding this comment.
This is how it looks:
PS /mnt/d/PSGit/PowerShell> Get-Item ./build.psm1 | fl UnixMode, UnixFileMode
UnixMode : -rwxrwxrwx
UnixFileMode : OtherExecute, OtherWrite, OtherRead, GroupExecute, GroupWrite, GroupRead, UserExecute, UserWrite, UserRe
ad
There was a problem hiding this comment.
Also, this:
PS /mnt/d/PSGit/PowerShell> Get-Item ./a.txt | fl UnixMode, UnixFileMode
UnixMode : -r-xr-xr-x
UnixFileMode : OtherExecute, OtherRead, GroupExecute, GroupRead, UserExecute, UserRead
They seems to be same. We may want to consider removing the script property. That is a different issue though
|
🎉 Handy links: |
Automated changes by create-pull-request GitHub action