Fix race condition between DisconnectAsync and Dispose#16536
Merged
iSazonov merged 4 commits intoPowerShell:masterfrom Dec 2, 2021
Merged
Fix race condition between DisconnectAsync and Dispose#16536iSazonov merged 4 commits intoPowerShell:masterfrom
iSazonov merged 4 commits intoPowerShell:masterfrom
Conversation
There is an inherent race condition in offloading to the ThreadPool. Dispose can run before RemoteSession.DisconnectAsync. This will result in an NRE inside ClientRemoteSession. An unhandled exception in a ThreadPool thread crashes the process.
PaulHigin
suggested changes
Dec 1, 2021
…ngProtocol2.cs Co-authored-by: Paul Higinbotham <paulhi@microsoft.com>
PaulHigin
approved these changes
Dec 1, 2021
iSazonov
reviewed
Dec 2, 2021
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
Collaborator
|
@i3arnon Thanks for your contribution! |
|
🎉 Handy links: |
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Make
StartDisconnectAsyncrunning on a background thread able to run afterDisposehas been invoked.PR Context
There is an inherent race condition in offloading to the
ThreadPool.Dispose can run before
RemoteSession.DisconnectAsync.This will result in an NRE inside
ClientRemoteSession.An unhandled exception in a
ThreadPoolthread crashes the process.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).