Skip to content

Use Convert-Path for unknown drive in Build.psm1#16416

Merged
anmenaga merged 1 commit intoPowerShell:masterfrom
matt9ucci:matt9ucci-fix-13201
Nov 30, 2021
Merged

Use Convert-Path for unknown drive in Build.psm1#16416
anmenaga merged 1 commit intoPowerShell:masterfrom
matt9ucci:matt9ucci-fix-13201

Conversation

@matt9ucci
Copy link
Copy Markdown
Contributor

@matt9ucci matt9ucci commented Nov 9, 2021

PR Summary

Fix #13201

PR Context

If we are at Temp:\, $PWD.Path returns Temp:\, unknown PSDrive for Windows PowerShell.
Instead, Convert-Path -Path $PWD.Path returns a standard FileSystem path like C:\Users\me\AppData\Local\Temp\. It can be handled by Windows PowerShell.

PR Checklist

@ghost ghost assigned anmenaga Nov 9, 2021
@pull-request-quantifier-deprecated
Copy link
Copy Markdown

pull-request-quantifier-deprecated Bot commented Nov 9, 2021

This PR has 2 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Extra Small
Size       : +1 -1
Percentile : 0.8%

Total files changed: 1

Change summary by file extension:
.psm1 : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detetcted.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Nov 9, 2021

There is #13202 also.

@matt9ucci
Copy link
Copy Markdown
Contributor Author

matt9ucci commented Nov 9, 2021

There is #13202 also.

#13202 uses Get-Item and modifies multiple lines, not only Install-Dotnet but also other functions.

This PR uses Convert-Path to resolve a PSDrive inherently and modifies just one line which is sufficient to fix #13201.

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Nov 10, 2021
@iSazonov iSazonov changed the title Use Convert-Path for unknown drive (fix #13201) Use Convert-Path for unknown drive in Build.psm1 Nov 10, 2021
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 19, 2021
@ghost
Copy link
Copy Markdown

ghost commented Nov 19, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@anmenaga anmenaga merged commit c2966ac into PowerShell:master Nov 30, 2021
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 30, 2021
@iSazonov
Copy link
Copy Markdown
Collaborator

iSazonov commented Dec 1, 2021

@matt9ucci Thanks for your contribution.

@matt9ucci matt9ucci deleted the matt9ucci-fix-13201 branch December 1, 2021 08:24
@ghost
Copy link
Copy Markdown

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 16, 2021
Closed
TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@matt9ucci @TrapGodBrim
Fix PowerShell#13201 (PowerShell#16416)
454a482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

1 more reviewer

@PaulHigin PaulHigin PaulHigin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga anmenaga

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log Extra Small

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

build.psm1: INSTALL-DOTNET fails when PWD is TEMP:\

4 participants

@matt9ucci @iSazonov @PaulHigin @anmenaga