Update metadata.json in preparation on 7.3.0-preview.1 release#16406
Update metadata.json in preparation on 7.3.0-preview.1 release#16406PaulHigin merged 2 commits intoPowerShell:masterfrom
metadata.json in preparation on 7.3.0-preview.1 release#16406Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
@PaulHigin Please re-review.. some changes with new commit. |
| private static readonly SemanticVersion s_psV62Version = new SemanticVersion(6, 2, 0, preReleaseLabel: null, buildLabel: null); | ||
| private static readonly SemanticVersion s_psV7Version = new SemanticVersion(7, 0, 0, preReleaseLabel: null, buildLabel: null); | ||
| private static readonly SemanticVersion s_psV71Version = new SemanticVersion(7, 1, 0, preReleaseLabel: null, buildLabel: null); | ||
| private static readonly SemanticVersion s_psV72Version = new SemanticVersion(7, 2, 0, preReleaseLabel: null, buildLabel: null); |
There was a problem hiding this comment.
Nit: I wonder we keep old and unsupported versions here
There was a problem hiding this comment.
@PaulHigin is the PSCompatibleEdition needed for remoting?
@PowerShell/powershell-maintainers -- what do you think? Should 6.2.0 be removed?
There was a problem hiding this comment.
I'd remove 1,2,3 and 6 version, and maybe 4 too.
|
🎉 Handy links: |
…owerShell#16406) * Update `metadata.json` in preparation on `7.3.0-preview.1` release * Update PSVersion table and tests
PR Summary
Update the metadata so dev build will pickup the correct version.
PR Context
Similar changes done for 7.1 -> 7.2 #14026
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).