Skip to content

Add wget as a dependency for installation script#16303

Merged
TravisEz13 merged 2 commits intoPowerShell:masterfrom
kondratyev-nv:fix_macos_bootstrap
Oct 26, 2021
Merged

Add wget as a dependency for installation script#16303
TravisEz13 merged 2 commits intoPowerShell:masterfrom
kondratyev-nv:fix_macos_bootstrap

Conversation

@kondratyev-nv
Copy link
Copy Markdown
Contributor

PR Summary

Add wget as a dependency for installation script.

PR Context

When building PowerShell with build.psm1 module, if wget is not installed bootstrap process would fail on macOS.

PS /Users/nik/Development/PowerShell> Start-PSBootstrap
Installing PowerShell build dependencies
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/cask).
==> Updated Casks
Updated 8 casks.

Warning: Treating cmake as a formula. For the cask, use homebrew/cask/cmake
Warning: cmake 3.21.3_1 is already installed and up-to-date.
To reinstall 3.21.3_1, run:
  brew reinstall cmake
Warning: openssl@3 3.0.0_1 is already installed and up-to-date.
To reinstall 3.0.0_1, run:
  brew reinstall openssl@3
WARNING: Could not find 'dotnet', appending /Users/nik/.dotnet to PATH.
WARNING: Still could not find 'dotnet', restoring PATH.
dotnet not present.  Installing dotnet.
Get-Command: /Users/nik/Development/PowerShell/build.psm1:1774:17
Line |
1774 |$wget = Get-Command -Name wget -CommandType Application -TotalCou …
     |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | The term 'wget' is not recognized as a name of a cmdlet, function, script file, or executable program. Check the spelling
     | of the name, or if a path was included, verify that the path is correct and try again.

After the changes

PS /Users/nik/Development/PowerShell> Start-PSBootstrap         
Installing PowerShell build dependencies
Warning: Treating cmake as a formula. For the cask, use homebrew/cask/cmake
Warning: cmake 3.21.3_1 is already installed and up-to-date.
To reinstall 3.21.3_1, run:
  brew reinstall cmake
Warning: openssl@3 3.0.0_1 is already installed and up-to-date.
To reinstall 3.0.0_1, run:
  brew reinstall openssl@3
Warning: Building wget from source as the bottle needs:
...
dotnet not present.  Installing dotnet.
--2021-10-25 23:08:36--  https://raw.githubusercontent.com/dotnet/cli/master/scripts/obtain/uninstall/dotnet-uninstall-pkgs.sh
Resolving raw.githubusercontent.com (raw.githubusercontent.com)... 185.199.109.133, 185.199.111.133, 185.199.110.133, ...
Connecting to raw.githubusercontent.com (raw.githubusercontent.com)|185.199.109.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 1191 (1.2K) [text/plain]
Saving to: dotnet-uninstall-pkgs.sh
...

Comment thread build.psm1
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 26, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 26, 2021
@TravisEz13 TravisEz13 merged commit d391168 into PowerShell:master Oct 26, 2021
@iSazonov
Copy link
Copy Markdown
Collaborator

@kondratyev-nv Thanks for your contribution!

@iSazonov iSazonov added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 27, 2021
@kondratyev-nv kondratyev-nv deleted the fix_macos_bootstrap branch October 27, 2021 13:50
@ghost
Copy link
Copy Markdown

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
* Add wget as a dependency for installation script

* Add wget as a dependency for alpine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants