Use 'PlainText' when writing to a host that doesn't support VT#16092
Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom Sep 15, 2021
Merged
Use 'PlainText' when writing to a host that doesn't support VT#16092adityapatwardhan merged 2 commits intoPowerShell:masterfrom
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
Conversation
SteveL-MSFT
requested changes
Sep 14, 2021
SteveL-MSFT
approved these changes
Sep 14, 2021
adityapatwardhan
approved these changes
Sep 14, 2021
iSazonov
reviewed
Sep 15, 2021
|
🎉 Handy links: |
5 tasks
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #15978
Update the
ShouldOutputPlainTextto take care of the situation when we are writing to a host that doesn't support VT.I manually verified that it suppresses the VT sequences on legacy console host:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.