Skip to content

Set locale correctly on Linux CI#16073

Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
daxian-dbw:fix-daily
Sep 9, 2021
Merged

Set locale correctly on Linux CI#16073
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
daxian-dbw:fix-daily

Conversation

@daxian-dbw
Copy link
Copy Markdown
Member

@daxian-dbw daxian-dbw commented Sep 9, 2021

PR Summary

Fixes daily CI issues on Linux where help tests fail due to bad locale settings.

Failed Linux daily CI: https://dev.azure.com/powershell/PowerShell/_build/results?buildId=86091&view=results

@ghost ghost assigned TravisEz13 Sep 9, 2021
@daxian-dbw daxian-dbw requested a review from rjmholt September 9, 2021 19:13
@daxian-dbw daxian-dbw assigned rjmholt and unassigned TravisEz13 Sep 9, 2021
@adityapatwardhan
Copy link
Copy Markdown
Member

adityapatwardhan commented Sep 9, 2021

Can you remove from here to:

PowerShell/.vsts-ci/templates/nix-test.yml

Lines 65 to 67 in 024f409

- pwsh: |
Import-Module .\build.psm1 -Force
Set-CorrectLocale

adityapatwardhan
adityapatwardhan requested changes Sep 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove similar code from nix-test.yml

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 9, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 9, 2021
@adityapatwardhan adityapatwardhan added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 9, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-rc.1 milestone Sep 9, 2021
@ghost ghost removed this from the 7.2.0-rc.1 milestone Sep 9, 2021
@ghost
Copy link
Copy Markdown

ghost commented Sep 9, 2021

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@adityapatwardhan adityapatwardhan merged commit 74e283c into PowerShell:master Sep 9, 2021
@adityapatwardhan adityapatwardhan added this to the 7.2.0-rc.1 milestone Sep 9, 2021
@daxian-dbw daxian-dbw deleted the fix-daily branch September 9, 2021 21:00
TravisEz13 pushed a commit that referenced this pull request Sep 29, 2021
@daxian-dbw @adityapatwardhan
Set locale correctly on Linux CI (#16073)
72c8c9b
@ghost
Copy link
Copy Markdown

ghost commented Dec 16, 2021

🎉v7.3.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@daxian-dbw @TrapGodBrim
Set locale correctly on Linux CI (PowerShell#16073)
d9f3ce7
TrapGodBrim pushed a commit to TrapGodBrim/PowerShell that referenced this pull request Jan 19, 2022
@daxian-dbw @TrapGodBrim
Set locale correctly on Linux CI (PowerShell#16073)
f907e3b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan adityapatwardhan adityapatwardhan approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga

@TravisEz13 TravisEz13 Awaiting requested review from TravisEz13

+1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt rjmholt

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.10

Development

Successfully merging this pull request may close these issues.

4 participants

@daxian-dbw @adityapatwardhan @rjmholt @TravisEz13