Set $? correctly for command expression with redirections#16046
Merged
rjmholt merged 1 commit intoPowerShell:masterfrom Sep 3, 2021
Merged
Set $? correctly for command expression with redirections#16046rjmholt merged 1 commit intoPowerShell:masterfrom
rjmholt merged 1 commit intoPowerShell:masterfrom
Conversation
5 tasks
rjmholt
approved these changes
Sep 3, 2021
Collaborator
|
Do we already have regression tests verifying that the |
Member
Author
Collaborator
|
The change that (seemingly) caused this one to crop up was the change for So I guess a test case would be: function fail {
[CmdletBinding()]
param()
try { throw } catch { $PSCmdlet.WriteError($_) }
}
fail
$? | Should -BeFalse
(fail)
$? | Should -BeFalse |
Member
|
Backport rejected as this does not meet the bar. This will cause a change in behavior for 7.0.x and 7.1.x. |
Member
Author
|
@vexx32 It still behaves as expected, but I don't know if we have such test already. I can add one if not.
|
TravisEz13
pushed a commit
that referenced
this pull request
Sep 29, 2021
|
🎉 Handy links: |
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #16033
This PR makes a small update to
ShouldSetExecutionStatusToSuccess(PipelineAst)to not exclude single expression with redirections, so that$?can be set to true properly for single-element pipeline that only contains a command expression with redirections.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.