Fomat-Wide: Fix Null Reference Exception (#15964)#15990
Merged
rjmholt merged 1 commit intoPowerShell:masterfrom Aug 25, 2021
DarylGraves:master
Merged
Fomat-Wide: Fix Null Reference Exception (#15964)#15990rjmholt merged 1 commit intoPowerShell:masterfrom DarylGraves:master
rjmholt merged 1 commit intoPowerShell:masterfrom
DarylGraves:master
Conversation
rjmholt
approved these changes
Aug 24, 2021
vexx32
reviewed
Aug 24, 2021
|
|
||
| sb.Append(GenerateRowField(values[k], _si.columnInfo[k].width, alignment[k], dc, addPadding)); | ||
| if (values[k].Contains(ESC)) | ||
| if (values[k] is not null && values[k].Contains(ESC)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (values[k] is not null && values[k].Contains(ESC)) | |
| if (values[k]?.Contains(ESC)) |
Collaborator
There was a problem hiding this comment.
if (values[k]?.Contains(ESC))
It is not work (can return null but bool is expected..
Contributor
Author
There was a problem hiding this comment.
Do I need to do anything here? Sorry, a bit new to this.
Collaborator
There was a problem hiding this comment.
Nah, you're fine. I misremembered how these operators work a little bit.
xtqqczze
pushed a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Sep 2, 2021
TravisEz13
pushed a commit
that referenced
this pull request
Sep 29, 2021
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
If statement changed to include an additional condition. This prevents Null Reference Exceptions with
Format-Wide Parent -AutoPR Context
An issue was raised (#15964) to inform of this.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).