Fix parsing Link headers with unquoted rel types#15973
Merged
daxian-dbw merged 1 commit intoPowerShell:masterfrom Aug 26, 2021
Merged
Fix parsing Link headers with unquoted rel types#15973daxian-dbw merged 1 commit intoPowerShell:masterfrom
daxian-dbw merged 1 commit intoPowerShell:masterfrom
Conversation
After this commit, Invoke-RestMethod can be used with -FollowRelLink when the link relation type is not surrounded by quotes. This was previously not possible because of a defective regex pattern. Resolves PowerShell#15972, PowerShell#11629
iSazonov
approved these changes
Aug 23, 2021
Collaborator
iSazonov
left a comment
There was a problem hiding this comment.
I remember I checked this previously and it worked. I must have picked the wrong site to test. :-(
@StevenLiekens Thanks for fixing this.
Collaborator
|
Is it possible to add test cases for this pattern so we can guard against regressions? |
daxian-dbw
approved these changes
Aug 26, 2021
Member
|
Thanks @StevenLiekens! |
xtqqczze
pushed a commit
to xtqqczze/PowerShell-PowerShell
that referenced
this pull request
Sep 2, 2021
22 tasks
|
🎉 Handy links: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
After this commit, Invoke-RestMethod can be used with -FollowRelLink when the link relation type is not surrounded by quotes. This was previously not possible because of a defective regex pattern.
PR Context
Resolves #15972, #11629
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).