Skip to content

Update .NET to version 6.0.100-preview.2.21155.3 - #15007

Merged
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:UpdateDotNet6p2
Mar 15, 2021
Merged

Update .NET to version 6.0.100-preview.2.21155.3#15007
Aditya Patwardhan (adityapatwardhan) merged 2 commits into
PowerShell:masterfrom
adityapatwardhan:UpdateDotNet6p2

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Mar 12, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

PR Summary

Update the .NET SDK to .NET 6 preview 2.

PR Context

PR Checklist

anmenaga
Andrew (anmenaga) suggested changes Mar 12, 2021
View reviewed changes
Comment thread src/System.Management.Automation/engine/hostifaces/PowerShell.cs Outdated

@anmenaga Andrew (anmenaga) Mar 12, 2021 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like it is related to bumping .NET version. Probably better to move this to a separate PR.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 12, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to this issue i reported: dotnet/roslyn#51849

Comment thread assets/wix/files.wxs Outdated

@anmenaga Andrew (anmenaga) Mar 12, 2021 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, why this System.Speech.dll is mentioned here (looks like it was added by this PR)?

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 12, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comes with the framework i guess

@iSazonov Ilya (iSazonov) Mar 13, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reported to .Net Runtime repo.

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 12, 2021
anmenaga
Andrew (anmenaga) reviewed Mar 12, 2021
View reviewed changes
Comment thread src/System.Management.Automation/System.Management.Automation.csproj Outdated

@anmenaga Andrew (anmenaga) Mar 12, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curios why System.Security.Cryptography.Pkcs was on version="5.0.1" while all neighbor items were on 6.0.0-preview.1 - is this expected or something we missed previously?

@iSazonov Ilya (iSazonov) Mar 13, 2021 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not all packages was updated in .Net Runtime for Preview.1. There are another packages like this.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Mar 15, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we missed updating a couple of packages for preview 1. Should not be a problem this release though.

@anmenaga Andrew (anmenaga) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Mar 12, 2021
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Mar 12, 2021
@adityapatwardhan

Aditya Patwardhan (adityapatwardhan) commented Mar 15, 2021

Copy link
Copy Markdown
Member Author

Snapstore has an outage which is cause the link tests to fail.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 5c4a80e into PowerShell:master Mar 15, 2021
@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) deleted the UpdateDotNet6p2 branch March 15, 2021 18:22
@ghost

Deleted user (ghost) commented Mar 16, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@adityapatwardhan
Update .NET to version 6.0.100-preview.2.21155.3 (PowerShell#15007)
e298aae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov left review comments
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+2 more reviewers
@anmenaga Andrew (anmenaga) anmenaga requested changes
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.4

Development

Successfully merging this pull request may close these issues.

4 participants

@adityapatwardhan @rjmholt @anmenaga @iSazonov