#4750 Fix Get-Date -UFormat %G and %g behavior by brianary · Pull Request #14555 · PowerShell/PowerShell

Brian Lalonde (brianary) · 2021-01-07T04:07:56Z

PR Summary

Corrects the behavior of %G and %g (variants of the same value) in Get-Date -UFormat to match ISO 8601.

PR Context

This is to fix one of the format issues in #4750.

PR Checklist

Ilya (iSazonov) · 2021-01-07T14:40:08Z

Brian Lalonde (@brianary) Please look test fails.

Brian Lalonde (brianary) · 2021-01-07T23:23:07Z

Tricky doing this blind.

Ilya (iSazonov) · 2021-01-08T09:06:00Z

Tricky doing this blind.

Every CI has Details button. Then you need to press "View more details on Azure Pipelines" on bottom of right column. There you can see whole build and test process. (And download artifacts too.)

Brian Lalonde (brianary) · 2021-01-08T11:57:37Z

Sure, I've figured out how to view the test details. I just meant I haven't been able to get a local build environment working yet, so I'm over-relying on the build server and tests still.

I'll get those names changed.

Ilya (iSazonov) · 2021-01-08T16:00:48Z

I just meant I haven't been able to get a local build environment working yet

You can open new issue and share what is problems you have so that we can help you. (Of cause if you plan to continue contributing.)

Deleted user (ghost) · 2021-01-16T02:00:17Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Andrew (anmenaga) · 2021-01-28T02:52:40Z

Would be good for WG-Engine (feels like this is the best match) to review this breaking change in Get-Date -UFormat.

Ilya (iSazonov) · 2021-01-28T04:03:10Z

Andrew (@anmenaga) You could directly request a review from Engine person.

Deleted user (ghost) · 2021-02-04T14:00:23Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Ilya (iSazonov) · 2021-02-04T17:35:17Z

Brian Lalonde (@brianary) Please resolve merge conflicts.

Ilya (iSazonov) · 2021-02-04T19:12:37Z

Brian Lalonde (@brianary) Please fix typo in your test file.

Brian Lalonde (brianary) · 2021-02-06T23:34:09Z

Just trying to keep up with master

Camel case for local vars, as suggested in PR. Co-authored-by: Ilya <darpa@yandex.ru>

Brian Lalonde (brianary) · 2021-02-18T02:24:37Z

Rob Holt (@rjmholt) I've implemented your suggestions and rebased from upstream master to try and simplify merging.

Brian Lalonde (brianary) · 2021-02-18T06:20:34Z

Ouch, not a lot of detail on those failing tests.

Ilya (iSazonov) · 2021-02-18T06:28:50Z

Brian Lalonde (@brianary) I have checked new tests on WSL with Linux date utility and I see we need to correct our tests.

Brian Lalonde (brianary) · 2021-02-18T06:38:24Z

Ilya (@iSazonov) I see one of the new years was wrong. Fixing…

Deleted user (ghost) · 2021-02-26T02:00:05Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Ilya (iSazonov) · 2021-03-02T12:29:27Z

Brian Lalonde (@brianary) Thanks for your contribution!

Brian Lalonde (brianary) · 2021-03-03T01:22:55Z

Happy to help!

Deleted user (ghost) · 2021-03-16T23:40:21Z

🎉v7.2.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

…14555)

ghost assigned Andrew (anmenaga) Jan 7, 2021

Ilya (iSazonov) self-requested a review January 7, 2021 14:40

Ilya (iSazonov) added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 7, 2021

Ilya (iSazonov) reviewed Jan 8, 2021

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Outdated

Ilya (iSazonov) approved these changes Jan 8, 2021

View reviewed changes

Ilya (iSazonov) added Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log Documentation Needed in this repo Documentation is needed in this repo labels Jan 8, 2021

ghost added the Review - Needed The PR is being reviewed label Jan 16, 2021

This was referenced Jan 24, 2021

#4750 Fix Get-Date -UFormat %u behavior #14549

Merged

Document Request: Get-Date -UFormat %G and %g (week year) MicrosoftDocs/PowerShell-Docs#7181

Closed

Andrew (anmenaga) added the WG-Engine core PowerShell engine, interpreter, and runtime label Jan 28, 2021

ghost removed the Review - Needed The PR is being reviewed label Jan 28, 2021

ghost added the Review - Needed The PR is being reviewed label Feb 4, 2021

ghost removed the Review - Needed The PR is being reviewed label Feb 4, 2021

Ilya (iSazonov) requested a review from Rob Holt (rjmholt) February 4, 2021 17:35

Ilya (iSazonov) removed the Documentation Needed in this repo Documentation is needed in this repo label Feb 4, 2021

Ilya (iSazonov) reviewed Feb 7, 2021

View reviewed changes

Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/Get-Date.Tests.ps1 Outdated

Rob Holt (rjmholt) reviewed Feb 16, 2021

View reviewed changes

Brian Lalonde (brianary) and others added 4 commits February 17, 2021 17:27

Issue #4750 Fix Get-Date -UFormat %G and %g behavior

dbf1528

Use correct naming convention

e3d7948

Camel case for local vars, as suggested in PR. Co-authored-by: Ilya <darpa@yandex.ru>

Finish renaming local vars

778b075

#4750 Fix Get-Date -UFormat %G and %g behavior

b11a036

Ilya (iSazonov) reviewed Feb 18, 2021

View reviewed changes

Comment thread src/Microsoft.PowerShell.Commands.Utility/commands/utility/GetDateCommand.cs Outdated

Ilya (iSazonov) self-requested a review February 18, 2021 06:29

Remove redundant ISO week calendar year code

8a27bb2

Ilya (iSazonov) approved these changes Feb 18, 2021

View reviewed changes

Rob Holt (rjmholt) approved these changes Feb 18, 2021

View reviewed changes

Rob Holt (rjmholt) added Area-Cmdlets-Utility WG-Engine core PowerShell engine, interpreter, and runtime and removed WG-Engine core PowerShell engine, interpreter, and runtime labels Feb 18, 2021

Sean Wheeler (sdwheeler) mentioned this pull request Feb 23, 2021

New (fixed) Get-Date -UFormat %G and %g behavior MicrosoftDocs/PowerShell-Docs#7182

Merged

23 tasks

ghost added the Review - Needed The PR is being reviewed label Feb 26, 2021

Andrew (anmenaga) merged commit c5955a5 into PowerShell:master Mar 2, 2021

ghost removed the Review - Needed The PR is being reviewed label Mar 2, 2021

Ilya (iSazonov) added this to the 7.2.0-preview.4 milestone Mar 2, 2021

Ilya (iSazonov) mentioned this pull request Mar 3, 2021

Get-Date -UFormat inconsistencies compared to Linux strftime #4750

Closed

14 tasks

Ryan Yates (kilasuit) added WG-Cmdlets general cmdlet issues and removed WG-Cmdlets-Utility labels Jul 17, 2026

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

PowerShell#4750 Fix Get-Date -UFormat %G and %g behavior (PowerShell#…

43dad57

…14555)

Uh oh!

Conversation

Brian Lalonde (brianary) commented Jan 7, 2021 • edited by iSazonov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Ilya (iSazonov) commented Jan 7, 2021

Uh oh!

Brian Lalonde (brianary) commented Jan 7, 2021

Uh oh!

Uh oh!

Ilya (iSazonov) commented Jan 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Brian Lalonde (brianary) commented Jan 8, 2021

Uh oh!

Ilya (iSazonov) commented Jan 8, 2021

Uh oh!

Deleted user (ghost) commented Jan 16, 2021

Uh oh!

Andrew (anmenaga) commented Jan 28, 2021

Uh oh!

Ilya (iSazonov) commented Jan 28, 2021

Uh oh!

Deleted user (ghost) commented Feb 4, 2021

Uh oh!

Ilya (iSazonov) commented Feb 4, 2021

Uh oh!

Ilya (iSazonov) commented Feb 4, 2021

Uh oh!

Brian Lalonde (brianary) commented Feb 6, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Brian Lalonde (brianary) commented Feb 18, 2021

Uh oh!

Uh oh!

Brian Lalonde (brianary) commented Feb 18, 2021

Uh oh!

Ilya (iSazonov) commented Feb 18, 2021

Uh oh!

Brian Lalonde (brianary) commented Feb 18, 2021

Uh oh!

Deleted user (ghost) commented Feb 26, 2021

Uh oh!

Ilya (iSazonov) commented Mar 2, 2021

Uh oh!

Brian Lalonde (brianary) commented Mar 3, 2021

Uh oh!

Deleted user (ghost) commented Mar 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Brian Lalonde (brianary) commented Jan 7, 2021 •

edited by iSazonov

Loading

Ilya (iSazonov) commented Jan 8, 2021 •

edited

Loading