Improve CommandInvocationIntrinsics API documentation and style#14369
Merged
daxian-dbw merged 3 commits intoPowerShell:masterfrom Sep 3, 2021
Merged
Conversation
iSazonov
reviewed
Dec 12, 2020
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
daxian-dbw
approved these changes
Jan 21, 2021
Member
|
@rjmholt @TravisEz13 Any changes needed for this PR? |
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
🎉 Handy links: |
TrapGodBrim
pushed a commit
to TrapGodBrim/PowerShell
that referenced
this pull request
Jan 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Using this API, I found I had to inspect the source code to determine the behaviour of the overloads I was looking over.
I've added comments so that in future that won't be necessary.
I think it's particularly interesting that the
stringoverloads execute in a local scope, while theScriptBlockoverloads dot-source — so this seems like an important thing to capture in documentation.I've also hung the parameters
and renamed one parameter because it was inconsistently named across overloads(reverted this second part since it's a breaking change for named parameters).PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.