Skip to content

Upgrade StyleCopAnalyzers to v1.2.0-beta.312 - #14354

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
xtqqczze:upgrade-stylecop
Dec 12, 2020
Merged

Upgrade StyleCopAnalyzers to v1.2.0-beta.312#14354
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
xtqqczze:upgrade-stylecop

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Dec 8, 2020

Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze mentioned this pull request Dec 8, 2020
Closed
@xtqqczze

xtqqczze commented Dec 9, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Could you please approve changes.

@iSazonov Ilya (iSazonov) added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Dec 9, 2020
@xtqqczze

xtqqczze commented Dec 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Reece Dunham (@RDIL) I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.

@iSazonov

Ilya (iSazonov) commented Dec 9, 2020

Copy link
Copy Markdown
Collaborator

Ilya (@iSazonov) Reece Dunham (@RDIL) I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.

They are large team and they can track manually.

We don't configure dependabot to auto-merge so I am ok if dependabot will create new PRs but only if new versions are not released frequently (monthly?).

@xtqqczze

xtqqczze commented Dec 9, 2020 •
edited by unfurl-links Bot
Loading

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Reece Dunham (@RDIL) I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.

They are large team and they can track manually.

We don't configure dependabot to auto-merge so I am ok if dependabot will create new PRs but only if new versions are not released frequently (monthly?).

I think releases may be more frequent until C# 9.0 support is complete. But generally releases happen less often, see https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases.

GitHub
An implementation of StyleCop rules using the .NET Compiler Platform - DotNetAnalyzers/StyleCopAnalyzers

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 41cfc4e into PowerShell:master Dec 12, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 12, 2020
@xtqqczze
xtqqczze deleted the upgrade-stylecop branch December 12, 2020 13:53
@ghost

Deleted user (ghost) commented Feb 12, 2021

Copy link
Copy Markdown

🎉v7.2.0-preview.3 has been released which incorporates this pull request.:tada:

Handy links:

Steg17
Steg17 reviewed Feb 21, 2021
View reviewed changes

@Steg17 Steg17 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Upgrade StyleCopAnalyzers to v1.2.0-beta.312 (PowerShell#14354)
c8d2c5d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daxian-dbw Dongbo Wang (daxian-dbw) daxian-dbw approved these changes
@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13
+1 more reviewer
@Steg17 Steg17 Steg17 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@daxian-dbw Dongbo Wang (daxian-dbw)

Labels

CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.2

Development

Successfully merging this pull request may close these issues.

4 participants

@xtqqczze @iSazonov @daxian-dbw @Steg17