Skip to content

Update dead link in Code Guidelines - #14314

Merged
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
iSazonov:fix-doc-link-codeguidelines
Dec 4, 2020
Merged

Update dead link in Code Guidelines#14314
Dongbo Wang (daxian-dbw) merged 2 commits into
PowerShell:masterfrom
iSazonov:fix-doc-link-codeguidelines

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Dec 4, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Fix #14313.
Update dead link in Code Guidelines to pass CIs.

PR Context

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label Dec 4, 2020
Comment thread docs/dev-process/coding-guidelines.md Outdated
* Make sure the added/updated comments are meaningful, accurate and easy to understand.

* Public members must use [doc comments](https://docs.microsoft.com/dotnet/csharp/programming-guide/xmldoc/xml-documentation-comments).
* Public members must use [doc comments](https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/xmldoc/).

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Public members must use [doc comments](https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/xmldoc/).
* Public members must use [doc comments](https://docs.microsoft.com/dotnet/csharp/programming-guide/xmldoc/).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 927d20a into PowerShell:master Dec 4, 2020
@iSazonov
Ilya (iSazonov) deleted the fix-doc-link-codeguidelines branch December 4, 2020 06:47
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 4, 2020
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 15, 2020
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken xmldoc link

3 participants