Skip to content

Use StringComparison.Ordinal insted of StringComparison.CurrentCulture at startup time - #14298

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
iSazonov:perf-startwith
Dec 2, 2020
Merged

Use StringComparison.Ordinal insted of StringComparison.CurrentCulture at startup time#14298
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:masterfrom
iSazonov:perf-startwith

Conversation

@iSazonov

@iSazonov Ilya (iSazonov) commented Dec 1, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Use StringComparison.Ordinal instead of default StringComparison.CurrentCulture.

This looks like a bug but discovered in startup scenario perf analyze - perf win 0.7% (5 ms - so long because of ICU initialization).

PR Context

Related #14268

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log label Dec 1, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator Author

Reopen to restart CIs.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 548e939 into PowerShell:master Dec 2, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 3, 2020
@iSazonov
Ilya (iSazonov) deleted the perf-startwith branch December 3, 2020 02:58
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Performance Indicates that a PR should be marked as a performance improvement in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants