Skip to content

Enable SA1504: All accessors should be single-line or multi-line - #14241

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:SA1504
Jan 9, 2021
Merged

Enable SA1504: All accessors should be single-line or multi-line#14241
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:SA1504

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 23, 2020

Copy link
Copy Markdown
Contributor

@xtqqczze

xtqqczze commented Nov 23, 2020

Copy link
Copy Markdown
Contributor Author

Depends on #14243.

@xtqqczze xtqqczze changed the title Enable SA1504: All accessors should be single-line or multi-line WIP: Enable SA1504: All accessors should be single-line or multi-line Nov 23, 2020
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 27, 2020
@xtqqczze xtqqczze changed the title WIP: Enable SA1504: All accessors should be single-line or multi-line Enable SA1504: All accessors should be single-line or multi-line Dec 11, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Dec 11, 2020
@xtqqczze xtqqczze closed this Dec 12, 2020
@xtqqczze xtqqczze reopened this Dec 12, 2020
@xtqqczze xtqqczze closed this Dec 13, 2020
@xtqqczze xtqqczze reopened this Dec 13, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review December 13, 2020 12:35
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Dec 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Dec 23, 2020
@ghost

Deleted user (ghost) commented Dec 23, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov
Ilya (iSazonov) merged commit b7a431a into PowerShell:master Jan 9, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Jan 9, 2021
@xtqqczze
xtqqczze deleted the SA1504 branch January 18, 2021 08:17
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@xtqqczze
Fix SA1504: All accessors should be single-line or multi-lin (PowerSh…
88356b3 
…ell#14241)

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1504.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) iSazonov approved these changes
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@daxian-dbw Dongbo Wang (daxian-dbw) Awaiting requested review from daxian-dbw daxian-dbw is a code owner

Assignees

@iSazonov Ilya (iSazonov)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.2.0-preview.3

Development

Successfully merging this pull request may close these issues.

3 participants

@xtqqczze @iSazonov @daxian-dbw