Skip to content

Enable nullable: System.Management.Automation.Language.ICustomAstVisitor2 - #14192

Merged
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
powercode:nullable/ICustomAstVisitor2
Dec 11, 2020
Merged

Enable nullable: System.Management.Automation.Language.ICustomAstVisitor2#14192
Ilya (iSazonov) merged 3 commits into
PowerShell:masterfrom
powercode:nullable/ICustomAstVisitor2

Conversation

@powercode

Copy link
Copy Markdown
Collaborator

Tracking issue: #12631.

@iSazonov Ilya (iSazonov) left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please move directives.

Comment thread src/System.Management.Automation/engine/parser/AstVisitor.cs
Comment thread src/System.Management.Automation/engine/parser/AstVisitor.cs Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 20, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 20, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 28, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov Ilya (iSazonov) self-assigned this Dec 11, 2020
@iSazonov
Ilya (iSazonov) merged commit 29131d5 into PowerShell:master Dec 11, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Dec 11, 2020
@powercode
Staffan Gustafsson (powercode) deleted the nullable/ICustomAstVisitor2 branch December 14, 2020 08:17
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants