Revert "Fix nullable usage on authenticode" - #14134
Merged
Merged
Conversation
Dongbo Wang (daxian-dbw)
requested review from
Ilya (iSazonov) and
Rob Holt (rjmholt)
November 18, 2020 21:22
Rob Holt (rjmholt)
approved these changes
Nov 19, 2020
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
…hell#13804)" (PowerShell#14134) This reverts commit 42e7b66.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
Nullable<T>.HasValuecheck is necesary, we should keep usingNullable<T>.Valueafter the check. Comparing toNullable<T>.GetValueOrDefault(), it's semantically more clear that "I want the current value, not the default value" in this case.Therefore, revert PR #13804 as agreed in #13791 (comment)