Skip to content

Fix whitespace issues - #14092

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:fix-whitespace
Nov 19, 2020
Merged

Fix whitespace issues#14092
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:fix-whitespace

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 14, 2020

Copy link
Copy Markdown
Contributor

Fix some whitespace issues using dotnet-format

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Please could you merge.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Test failures due to HTTP error 503 (Service Unavailable) in package restore. Since these are trivial changes, I will not restart tests.

@iSazonov

Ilya (iSazonov) commented Nov 14, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

GitHub
PowerShell for every system! Contribute to iSazonov/PowerShell development by creating an account on GitHub.

@xtqqczze

xtqqczze commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

Yep looks likes a conflict between #13496 and #13872, TestPriority is now named Priority.

@xtqqczze

xtqqczze commented Nov 15, 2020

Copy link
Copy Markdown
Contributor Author

xtqqczze Please add new commit and replace [Fact, TestPriority(11)] with [Fact] to pass CI.
https://github.com/iSazonov/PowerShell/blob/54d3ae20c56b845d12414780cfcfcbc4e4684337/test/xUnit/csharp/test_PSConfiguration.cs#L971
(We merged old PR and get the minor regression.)

Yep looks likes a conflict between #13496 and #13872, TestPriority is now named Priority.

Fix merged in #14094.

@iSazonov

Copy link
Copy Markdown
Collaborator

xtqqczze Please rebase.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Pleases merge.

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 19, 2020
@iSazonov
Ilya (iSazonov) merged commit c9df1c1 into PowerShell:master Nov 19, 2020
@xtqqczze
xtqqczze deleted the fix-whitespace branch November 19, 2020 11:44
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants