Skip to content

Enable nullable: System.Management.Automation.Language.ISupportsTypeCaching - #14088

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:nullable-ISupportsTypeCaching
Jan 9, 2021
Merged

Enable nullable: System.Management.Automation.Language.ISupportsTypeCaching#14088
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:nullable-ISupportsTypeCaching

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 13, 2020

Copy link
Copy Markdown
Contributor

Tracking issue: #12631.

Comment thread src/System.Management.Automation/engine/parser/ast.cs Outdated
@xtqqczze
xtqqczze marked this pull request as ready for review November 14, 2020 01:28
@iSazonov

Copy link
Copy Markdown
Collaborator

xtqqczze We will move faster if we follow our plan - one type per PR without fixing usages of the type.

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 21, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@iSazonov

Copy link
Copy Markdown
Collaborator

ITypeName is in another PR - please remove.

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 23, 2020
@xtqqczze xtqqczze changed the title Enable nullable: System.Management.Automation.Language.ISupportsTypeCaching etc Enable nullable: System.Management.Automation.Language.ISupportsTypeCaching Nov 23, 2020
@xtqqczze
xtqqczze force-pushed the nullable-ISupportsTypeCaching branch from 46fc9c9 to 64f699e Compare November 23, 2020 09:37
@xtqqczze

Copy link
Copy Markdown
Contributor Author

rebased to restrict changes to ISupportsTypeCaching

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 23, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Nov 30, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Staffan Gustafsson (@powercode) Can you review?

@ghost ghost removed the Review - Needed The PR is being reviewed label Jan 9, 2021
@iSazonov
Ilya (iSazonov) merged commit 4480ee5 into PowerShell:master Jan 9, 2021
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.3 milestone Jan 9, 2021

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants