Enable CA1816: Dispose methods should call SuppressFinalize - #14074
Merged
Conversation
xtqqczze
marked this pull request as ready for review
November 13, 2020 21:45
xtqqczze
requested review from
Aditya Patwardhan (adityapatwardhan) and
Dongbo Wang (daxian-dbw)
as code owners
November 13, 2020 21:45
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
Ilya (iSazonov)
requested changes
Nov 21, 2020
Ilya (iSazonov)
approved these changes
Nov 22, 2020
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816
Also, ensure correct dispose pattern methods are present:
public void Dispose()protected virtual void Dispose(bool disposing)