Skip to content

Fix RCS1049: Simplify boolean comparison - #13994

Merged
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:RCS1049
Nov 13, 2020
Merged

Fix RCS1049: Simplify boolean comparison#13994
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:RCS1049

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Nov 6, 2020

Copy link
Copy Markdown
Contributor

https://github.com/JosefPihrt/Roslynator/blob/master/docs/analyzers/RCS1049.md

This PR includes changes to ComInterop that have also been made in dotnet/runtime#44564.

Comment thread src/System.Management.Automation/engine/Modules/ModuleCmdletBase.cs Outdated
Comment thread src/System.Management.Automation/engine/remoting/commands/InvokeCommandCommand.cs Outdated
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 6, 2020
@ghost ghost removed this from the 7.2.0-preview.1 milestone Nov 6, 2020
@ghost

Copy link
Copy Markdown

Open PRs should not be assigned to milestone, so they are not assigned to the wrong milestone after they are merged. For backport consideration, use a backport label.

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 6, 2020
Co-authored-by: Ilya <darpa@yandex.ru>
@xtqqczze

xtqqczze commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

This PR makes changes to ComInterop, so a corresponding PR has been opened at dotnet/runtime#44564.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

dotnet/runtime#44564 is approved.

@xtqqczze

Copy link
Copy Markdown
Contributor Author

dotnet/runtime#44564 is merged.

@iSazonov Ilya (iSazonov) self-assigned this Nov 13, 2020
@iSazonov
Ilya (iSazonov) merged commit b521b85 into PowerShell:master Nov 13, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 13, 2020
@xtqqczze
xtqqczze deleted the RCS1049 branch November 13, 2020 05:31
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants