Skip to content

Fix CA1003: Use generic event handler instances - #13937

Merged
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:CA1003
Nov 7, 2020
Merged

Fix CA1003: Use generic event handler instances#13937
Ilya (iSazonov) merged 1 commit into
PowerShell:masterfrom
xtqqczze:CA1003

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Oct 30, 2020

Copy link
Copy Markdown
Contributor

https://docs.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1003

This PR does not contain code fixes for public API surfaces, so the changes should not be breaking.

@xtqqczze
xtqqczze marked this pull request as ready for review October 30, 2020 01:12
Comment thread .globalconfig
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 30, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost added the Review - Needed The PR is being reviewed label Nov 7, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 7, 2020
@iSazonov
Ilya (iSazonov) merged commit 2e24380 into PowerShell:master Nov 7, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 7, 2020
@xtqqczze
xtqqczze deleted the CA1003 branch November 7, 2020 16:23
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants