Add global AnalyzerConfig with default configuration#13835
Add global AnalyzerConfig with default configuration#13835iSazonov merged 3 commits intoPowerShell:masterfrom
Conversation
|
Why not follow https://github.com/dotnet/runtime/blob/master/eng/Analyzers.props?
|
|
My thought was and is that we shouldn't have two configs - in EditorConfig and in ruleset. If VS Code supports(?) ruleset it is better to use ruleset and follow .Net team's pattern. |
This comment has been minimized.
This comment has been minimized.
2a3256e to
d90a6f9
Compare
Add `microsoft.codeanalysis.netanalyzers\5.0.0-rtm.20502.2\editorconfig\AllRulesDefault\.editorconfig`
d90a6f9 to
13d0258
Compare
|
@iSazonov This PR uses |
Copied from: <https://github.com/stephentoub/runtime/blob/3b6600cbefe6b96706c5315ce184accbb4501f3b/eng/CodeAnalysis.ruleset> and converted using `RulesetToEditorconfigConverter.exe`
|
I will merge because:
As a side notice, we could disable Analyzers in all CIs to speed up compiling and separate check (compile only) with enabled analyzers. |
|
🎉 Handy links: |
PR Summary
microsoft.codeanalysis.netanalyzers/5.0.0-rtm.20502.2/editorconfig/AllRulesDefault/.editorconfigto.globalconfig.globalconfigwith most rules hiddenRulesetToEditorconfigConverter.exeMicrosoft.Management.UI.InternalPR Context
Alternative to #12892
If Visual Studio 2019 is installed, it should be updated to 16.8 Preview5+ because OmniSharp appears to prefer the Visual Studio MSBuild instance to the StandAlone instance. Otherwise, the global AnalyzerConfig may be ignored.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.