fix(engine): nullable - #13801
Closed
Ron Green (georgettica) wants to merge 1 commit into
Closed
Conversation
this one is more tricky as there are keyvaluepairs in here I might have missed one or two
Contributor
Author
|
Not surprising, this was a massive change.. Planning to fix with visual studio and hopefully will work much better |
Ilya (iSazonov)
left a comment
Collaborator
There was a problem hiding this comment.
Ron Green (@georgettica) Too many errors. Please fix based on my comments.
| PSPropertyInfo nameProperty = psObject.Properties["Name"]; | ||
| PSPropertyInfo psSnapInProperty = psObject.Properties["PSSnapIn"]; | ||
| string nameString = nameProperty == null ? string.Empty : (string)nameProperty.Value; | ||
| string psSnapInString = psSnapInProperty == null ? string.Empty : (string)psSnapInProperty.Value; |
Collaborator
There was a problem hiding this comment.
It is not correct. See my comment in another PR.
| } | ||
|
|
||
| result.Add(param, pair.Value); | ||
| result.Add(param, pair); |
Collaborator
There was a problem hiding this comment.
It is not nullable.
Contributor
Author
|
will remove this PR aswell as I think some stuff will be better suited by others |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this one is more tricky as there are keyvaluepairs in here
I might have missed one or two
same as #13793
related to #13791